bug#36557: 27.0.50; Duplicated check in octave-mode ElDoc support

bug#36557: 27.0.50; Duplicated check in octave-mode ElDoc support

[Mauro Aranda]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

Hello.

In octave-eldoc-function, there is a duplicated check for the position
of the opening parenthesis when the current buffer is the inferior
octave buffer.

I'll send a patch when assigned a bug number.

Best regards,
Mauro.

[-- Attachment #2: Type: text/html, Size: 287 bytes --]

bug#36557: 27.0.50; Duplicated check in octave-mode ElDoc support

[Mauro Aranda]

[-- Attachment #1.1: Type: text/plain, Size: 29 bytes --]

Tags: patch

Patch attached.

[-- Attachment #1.2: Type: text/html, Size: 85 bytes --]

[-- Attachment #2: 0001-Remove-duplicated-code-in-octave-eldoc-function.patch --]
[-- Type: text/x-patch, Size: 1457 bytes --]

From 3283696088d4881b06185ed8fa8b74f94e2cbaeb Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Mon, 8 Jul 2019 19:22:20 -0300
Subject: [PATCH] Remove duplicated code in octave-eldoc-function

* lisp/progmodes/octave.el (octave-eldoc-function): The position of
the opening parenthesis in the inferior-octave-process was
duplicated.  Remove one of the checks.  (Bug#36557)
---
 lisp/progmodes/octave.el | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/lisp/progmodes/octave.el b/lisp/progmodes/octave.el
index 8a7e24e..6e59401 100644
--- a/lisp/progmodes/octave.el
+++ b/lisp/progmodes/octave.el
@@ -1630,12 +1630,7 @@ octave-eldoc-function
            (paren-pos (cadr ppss))
            (fn (save-excursion
                  (if (and paren-pos
-                          ;; PAREN-POS must be after the prompt
-                          (>= paren-pos
-                              (if (eq (get-buffer-process (current-buffer))
-                                      inferior-octave-process)
-                                  (process-mark inferior-octave-process)
-                                (point-min)))
+                          ;; PAREN-POS must be after the prompt.
                           (or (not (eq (get-buffer-process (current-buffer))
                                        inferior-octave-process))
                               (< (process-mark inferior-octave-process)
-- 
2.7.4

bug#36557: 27.0.50; Duplicated check in octave-mode ElDoc support

[Eli Zaretskii]

> From: Mauro Aranda <maurooaranda@gmail.com>
> Date: Mon, 8 Jul 2019 20:00:34 -0300
> 
> Tags: patch
> 
> Patch attached.

Thanks, pushed to the master branch.