bug#56535: 28.1; `no' and `no-ding' values for isearch-wrap-pause option (since Emacs 28.1) not working as documented

[Arun V <arunlalv04@gmail.com>]

Definitely ding. Lot of people do prefer visual feedback.

How about this?

  :type '(choice (const :tag "Pause before wrapping" t)
                 (const :tag "No pause before wrapping for
non-incremental search" nis-no)
                 (const :tag "No pause and no flashing for
non-incremental search" nis-no-ding)
                 (const :tag "Absolutely no pause before wrapping" no)
 ;;This will cover non-incremental searches as well
                 (const :tag "Absolutely no pause and no flashing"
no-ding)  ;;This will cover non-incremental searches as well
                 (const :tag "Disable wrapping" nil))

On Mon, 18 Jul 2022 at 01:05, Juri Linkov <juri@linkov.net> wrote:
>
> >>> Please try the following patch after setting isearch-wrap-pause to the
> >>> new value 'auto-repeat':
> >>>
> >> Regret the delayed response.
> >>
> >> Yes, I do believe this would be a good idea.
> >>
> >> Let me try this patch atop emacs-28.1 and get back to you.
> >
> > Thanks Juri. Your patch works.
>
> No problem with the delay.  Thanks for confirming that it works.
>
> Now we have to find a better name to describe what it really does.
> Probably it should have the prefix "no-" since it makes no pause
> like the existing two values 'no' and 'no-ding':
>
>   :type '(choice (const :tag "Pause before wrapping" t)
>                  (const :tag "No pause before wrapping" no)
>                  (const :tag "No pause and no flashing" no-ding)
>                  (const :tag "Disable wrapping" nil))
>
> This raises the question: should it ding and flash on wrapping?
> Or two new separate values are needed: one to ding when wrapping
> on typing a character, and another not to ding?  To ding, or not to ding?



-- 
--
Thanks and regards,
Arunlal Venugopal