bug#54410: One cl-defgeneric in xref.el should be cl-defmethod

bug#54410: One cl-defgeneric in xref.el should be cl-defmethod

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Tags: patch

Is the following patch good for the release branch?



In GNU Emacs 28.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.31, cairo version 1.16.0)
 of 2022-03-14
Repository revision: 8e7a3f21e00649bacc01be627edd45ff01b51a33
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Debian GNU/Linux rodete

Configured using:
 'configure --enable-gcc-warnings=warn-only
 --enable-gtk-deprecation-warnings --without-pop --with-mailutils
 --enable-checking=all --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: xref-defmethod.patch --]
[-- Type: text/patch, Size: 448 bytes --]

diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index 2fd5e19237..aefee31897 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -220,7 +220,7 @@ xref-location-group
   "A match xref item describes a search result."
   length)
 
-(cl-defgeneric xref-match-length ((item xref-match-item))
+(cl-defmethod xref-match-length ((item xref-match-item))
   "Return the length of the match."
   (xref-match-item-length item))
 

[-- Attachment #3: Type: text/plain, Size: 709 bytes --]


-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich.  Falls Sie diese fälschlicherweise erhalten haben
sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie
alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail
an die falsche Person gesendet wurde.

This e-mail is confidential.  If you received this communication by mistake,
please don’t forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

bug#54410: One cl-defgeneric in xref.el should be cl-defmethod

[Eli Zaretskii]

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Wed, 16 Mar 2022 00:09:23 +0100
> 
> Is the following patch good for the release branch?

What problems are caused by the current code?

In general, I'd prefer to leave the release branch alone at this time,
so we could release Emacs 28.1 soon.  It seems quite ready.

bug#54410: One cl-defgeneric in xref.el should be cl-defmethod

[Dmitry Gutov]

On 16.03.2022 05:29, Eli Zaretskii wrote:
> What problems are caused by the current code?

I think it will cause no change in observable behavior, it's closer to 
the realm of better documentation.

The change should be very safe accordingly, though.

bug#54410: One cl-defgeneric in xref.el should be cl-defmethod

[Eli Zaretskii]

> Date: Wed, 16 Mar 2022 14:14:38 +0200
> Cc: 54410@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> 
> On 16.03.2022 05:29, Eli Zaretskii wrote:
> > What problems are caused by the current code?
> 
> I think it will cause no change in observable behavior, it's closer to 
> the realm of better documentation.

Thanks, but that's not exactly what I asked.

bug#54410: One cl-defgeneric in xref.el should be cl-defmethod

[Lars Ingebrigtsen]

Dmitry Gutov <dgutov@yandex.ru> writes:

> I think it will cause no change in observable behavior, it's closer to
> the realm of better documentation.
>
> The change should be very safe accordingly, though.

I think it would be better to push it to master.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54410: One cl-defgeneric in xref.el should be cl-defmethod

[Dmitry Gutov]

On 17.03.2022 13:01, Lars Ingebrigtsen wrote:
> I think it would be better to push it to master.

Fine with me.

bug#54410: One cl-defgeneric in xref.el should be cl-defmethod

[Philipp Stephani]

Am Mi., 16. März 2022 um 04:29 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Wed, 16 Mar 2022 00:09:23 +0100
> >
> > Is the following patch good for the release branch?
>
> What problems are caused by the current code?

I'm using Edebug for coverage instrumentation, and that only works
right in an automated way if there are no duplicate instrumented
symbols, because Edebug attaches coverage information to individual
symbols. cl-defmethod takes care of this by generating additional
symbols, but cl-defgeneric doesn't.

>
> In general, I'd prefer to leave the release branch alone at this time,
> so we could release Emacs 28.1 soon.  It seems quite ready.

Fine with me, I've pushed it to master as commit
6ed3f04e5a3c8aee40a26805bb00cdd070eba319.