bug#24679: 26.0.50; Flymake should clear the query-on-exit flag

bug#24679: 26.0.50; Flymake should clear the query-on-exit flag

[Philipp Stephani]

This was already proposed in
https://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01217.html,
but there was no follow-up.  Flymake processes are expected to be
unimportant and stateless, so I think it would be better to clear their
query-on-exit flag.  Flycheck does likewise
(https://github.com/flycheck/flycheck/blob/e86fa19af782109645ce5f9680eaa52e64e7092a/flycheck.el#L4925).


In GNU Emacs 26.0.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2016-10-12 built on localhost
Repository revision: 59c5f36acfcbec4f6119996f7b80383bf86125d4
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description:	Ubuntu 14.04 LTS

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --with-modules --enable-checking
 --enable-check-lisp-object-type'

Configured features:
XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 MODULES

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv
bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib
dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec
password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils time-date mule-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 97770 7275)
 (symbols 48 20416 0)
 (miscs 40 325 119)
 (strings 32 17960 4918)
 (string-bytes 1 590510)
 (vectors 16 13792)
 (vector-slots 8 454069 5966)
 (floats 8 183 16)
 (intervals 56 215 0)
 (buffers 976 12)
 (heap 1024 19229 1044))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich.  Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen
Sie die E-Mail und alle Anhänge.  Vielen Dank.

This e-mail is confidential.  If you are not the right addressee please do not
forward it, please inform the sender, and please erase this e-mail including
any attachments.  Thanks.

bug#24679: 26.0.50; Flymake should clear the query-on-exit flag

[Leo Liu]

On 2016-10-12 22:08 +0200, Philipp Stephani wrote:
> This was already proposed in
> https://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01217.html,
> but there was no follow-up. Flymake processes are expected to be
> unimportant and stateless, so I think it would be better to clear
> their query-on-exit flag.

 👍

That looks like a good change.

Leo

bug#24679: 26.0.50; Flymake should clear the query-on-exit flag

[Philipp Stephani]

[-- Attachment #1.1: Type: text/plain, Size: 559 bytes --]

Leo Liu <sdl.web@gmail.com> schrieb am Do., 13. Okt. 2016 um 06:12 Uhr:

> On 2016-10-12 22:08 +0200, Philipp Stephani wrote:
>
> > This was already proposed in
>
> > https://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01217.html,
>
> > but there was no follow-up. Flymake processes are expected to be
>
> > unimportant and stateless, so I think it would be better to clear
>
> > their query-on-exit flag.
>
>
>
>  👍
>
>
>
> That looks like a good change.
>
>
>
Thanks. I've attached a patch that also contains a NEWS entry.

[-- Attachment #1.2: Type: text/html, Size: 1173 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Don-t-prompt-user-when-killing-Flymake-processes.txt --]
[-- Type: text/plain; charset=US-ASCII;  name="0001-Don-t-prompt-user-when-killing-Flymake-processes.txt", Size: 2220 bytes --]

From 000baf0d1ea4625af61c6623b53457b38f2afaf4 Mon Sep 17 00:00:00 2001
From: Karl Chen <Karl.Chen@quarl.org>
Date: Sat, 15 Oct 2016 22:16:26 +0200
Subject: [PATCH] Don't prompt user when killing Flymake processes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* lisp/progmodes/flymake.el (flymake-start-syntax-check-process):
Don’t prompt the user when killing Flymake processes.

* doc/misc/flymake.texi (Starting the syntax check process):
Document new behavior.
---
 doc/misc/flymake.texi     | 3 ++-
 etc/NEWS                  | 6 ++++++
 lisp/progmodes/flymake.el | 1 +
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/doc/misc/flymake.texi b/doc/misc/flymake.texi
index 1c4644b..998f1b3 100644
--- a/doc/misc/flymake.texi
+++ b/doc/misc/flymake.texi
@@ -697,7 +697,8 @@ Starting the syntax check process
 initialization function.  Flymake then just calls @code{start-process}
 to start an asynchronous process and configures a process filter and
 sentinel, which are used for processing the output of the syntax check
-tool.
+tool.  When exiting Emacs, running Flymake processes will be killed
+without prompting the user.
 
 @node Parsing the output
 @section Parsing the output
diff --git a/etc/NEWS b/etc/NEWS
index 14450a6..fcfe550 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -466,6 +466,12 @@ This is done with the help of 'c-or-c++-mode' function which analyses
 contents of the buffer to determine whether it's a C or C++ source
 file.
 
+** Flymake
+
++++
+*** Emacs does no longer prompt the user before killing Flymake
+processes on exit.
+
 \f
 * New Modes and Packages in Emacs 26.1
 
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 30c9fed..1b78823 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1072,6 +1072,7 @@ flymake-start-syntax-check-process
                        "flymake-proc" (current-buffer) cmd args))))
         (set-process-sentinel process 'flymake-process-sentinel)
         (set-process-filter process 'flymake-process-filter)
+        (set-process-query-on-exit-flag process nil)
         (push process flymake-processes)
 
         (setq flymake-is-running t)
-- 
2.10.1

bug#24679: 26.0.50; Flymake should clear the query-on-exit flag

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

Philipp Stephani <p.stephani2@gmail.com> schrieb am Sa., 15. Okt. 2016 um
22:20 Uhr:

> Leo Liu <sdl.web@gmail.com> schrieb am Do., 13. Okt. 2016 um 06:12 Uhr:
>
> On 2016-10-12 22:08 +0200, Philipp Stephani wrote:
>
> > This was already proposed in
>
> > https://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01217.html,
>
> > but there was no follow-up. Flymake processes are expected to be
>
> > unimportant and stateless, so I think it would be better to clear
>
> > their query-on-exit flag.
>
>
>
>  👍
>
>
>
> That looks like a good change.
>
>
>
> Thanks. I've attached a patch that also contains a NEWS entry.
>

Since there were no further complaints, I've pushed the change to master.

[-- Attachment #2: Type: text/html, Size: 2044 bytes --]