bug#52430: 29.0.50; em-ls-tests failing on macOS

bug#52430: 29.0.50; em-ls-tests failing on macOS

[Philipp]

On my macOS Monterey machine, the em-ls-tests fail partially, both on
master and emacs-28.  Log follows:

Running 4 tests (2021-12-11 14:23:53+0100, selector `(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))')
   passed  1/4  em-ls-test-bug27631 (0.107104 sec)
   passed  2/4  em-ls-test-bug27817 (0.014281 sec)
   passed  3/4  em-ls-test-bug27843 (0.000889 sec)
Test em-ls-test-bug27844 backtrace:
  signal(error ("No matches found: /Users/p/Entwicklung/emacs/maste...
  error("No matches found: %s" "/Users/p/Entwicklung/emacs/master/lisp
  eshell-extended-glob("/Users/p/Entwicklung/emacs/master/lisp/*.el")
  eshell-ls--insert-directory(#f(compiled-function (file switches &opt
  apply(eshell-ls--insert-directory #f(compiled-function (file switche
  insert-directory("/Users/p/Entwicklung/emacs/master/lisp/*.el" "-al"
  dired-insert-directory("/Users/p/Entwicklung/emacs/master/lisp/*.el"
  dired-readin-insert()
  #f(compiled-function () #<bytecode -0x739e62c2245ec4>)()
  combine-change-calls-1(1 1 #f(compiled-function () #<bytecode -0x739
  dired-readin()
  dired-internal-noselect("/Users/p/Entwicklung/emacs/master/lisp/*.el
  dired-noselect("/Users/p/Entwicklung/emacs/master/lisp/*.el" nil)
  #f(compiled-function (dirname &optional switches) "\"Edit\" director
  eshell-ls--dired(#f(compiled-function (dirname &optional switches) "
  apply(eshell-ls--dired #f(compiled-function (dirname &optional switc
  dired("/Users/p/Entwicklung/emacs/master/lisp/*.el")
  #f(compiled-function () #<bytecode -0x1d720ed565db787c>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name em-ls-test-bug27844 :documentation "T
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/em-ls-tests" 
  command-line()
  normal-top-level()
Test em-ls-test-bug27844 condition:
    (error "No matches found: /Users/p/Entwicklung/emacs/master/lisp/*.el")
   FAILED  4/4  em-ls-test-bug27844 (0.047331 sec)

Ran 4 tests, 3 results as expected, 1 unexpected (2021-12-11 14:23:54+0100, 0.381777 sec)

1 unexpected results:
   FAILED  em-ls-test-bug27844

The directory /Users/p/Entwicklung/emacs/master/lisp/ is correct
(i.e. the lisp sources are there), so this might be an incorrect `ls'
invocation that assumes GNU ls.


In GNU Emacs 29.0.50 (build 25, aarch64-apple-darwin21.1.0, NS appkit-2113.00 Version 12.0.1 (Build 21A559))
 of 2021-12-11
Repository revision: 8c50016b100ec2c548ec90131e0f5fb5f4ebb5c1
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.0.1

Configured using:
 'configure --with-modules --without-xml2 --without-pop --with-mailutils
 --enable-gcc-warnings=warn-only --enable-checking=all
 --enable-check-lisp-object-type '--prefix=/tmp/\7''

Configured features:
ACL GNUTLS JSON LCMS2 MODULES NOTIFY KQUEUE NS PDUMPER PNG SQLITE3
THREADS TOOLKIT_SCROLL_BARS ZLIB

Important settings:
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message yank-media rmc dired
dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config gnus-util
rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived pcase
ffap thingatpt url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf url-util url-parse auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars
mailcap rx gnutls puny dbus xml seq gv subr-x byte-opt bytecomp
byte-compile cconv compile text-property-search comint ansi-color ring
cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win
ucs-normalize mule-util term/common-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice
button loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads kqueue cocoa ns lcms2
multi-tty make-network-process emacs)

Memory information:
((conses 16 70019 6915)
 (symbols 48 8477 1)
 (strings 32 23897 1585)
 (string-bytes 1 779203)
 (vectors 16 16571)
 (vector-slots 8 214734 10495)
 (floats 8 27 36)
 (intervals 56 225 0)
 (buffers 992 10))

bug#52430: 29.0.50; em-ls-tests failing on macOS

[Lars Ingebrigtsen]

Philipp <p.stephani2@gmail.com> writes:

> On my macOS Monterey machine, the em-ls-tests fail partially, both on
> master and emacs-28.  Log follows:
>
> Running 4 tests (2021-12-11 14:23:53+0100, selector `(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))')
>    passed  1/4  em-ls-test-bug27631 (0.107104 sec)
>    passed  2/4  em-ls-test-bug27817 (0.014281 sec)
>    passed  3/4  em-ls-test-bug27843 (0.000889 sec)
> Test em-ls-test-bug27844 backtrace:
>   signal(error ("No matches found: /Users/p/Entwicklung/emacs/maste...

I'm unable to reproduce this on the trunk on my Monterey laptop (with
Macports).  Could your system be using a different ls than mine or
something?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#52430: 29.0.50; em-ls-tests failing on macOS

[Philipp Stephani]

Am So., 12. Dez. 2021 um 07:00 Uhr schrieb Lars Ingebrigtsen <larsi@gnus.org>:
>
> Philipp <p.stephani2@gmail.com> writes:
>
> > On my macOS Monterey machine, the em-ls-tests fail partially, both on
> > master and emacs-28.  Log follows:
> >
> > Running 4 tests (2021-12-11 14:23:53+0100, selector `(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))')
> >    passed  1/4  em-ls-test-bug27631 (0.107104 sec)
> >    passed  2/4  em-ls-test-bug27817 (0.014281 sec)
> >    passed  3/4  em-ls-test-bug27843 (0.000889 sec)
> > Test em-ls-test-bug27844 backtrace:
> >   signal(error ("No matches found: /Users/p/Entwicklung/emacs/maste...
>
> I'm unable to reproduce this on the trunk on my Monterey laptop (with
> Macports).  Could your system be using a different ls than mine or
> something?

Looks like the problem is that eshell-extended-glob doesn't correctly
case-fold filenames on macOS:
$ mkdir -p /tmp/foo
$ touch /tmp/foo/bar
$ emacs -Q -batch -l em-glob -eval '(print (eshell-extended-glob "/tmp/FOO/*"))'
"/tmp/FOO/*"

In my case, the realpath of the Emacs source directory is actually
~/Entwicklung/Emacs/master (note the capital E), but my filesystem is
case-insensitive (as is the default on macOS).