bug#30031: 27.0.50; (make-process :noquery t) doesn't work with stderr buffer

bug#30031: 27.0.50; (make-process :noquery t) doesn't work with stderr buffer

[Philipp Stephani]

$ src/emacs -Q --eval '(progn (make-process :name "foo" :command (list "sleep" "1h") :noquery t) (save-buffers-kill-emacs))'

works as expected, i.e. Emacs doesn't ask about terminating the process.

But:

$ src/emacs -Q --eval '(progn (make-process :name "foo" :command (list "sleep" "1h") :noquery t :stderr (get-buffer-create "*stderr*")) (save-buffers-kill-emacs))'

will ask about terminating the process.  Adding a buffer for stderr
shouldn't make a difference here.


In GNU Emacs 27.0.50 (build 17, x86_64-pc-linux-gnu, GTK+ Version 3.22.24)
 of 2018-01-08 built on localhost
Repository revision: a0365437c9ee308ad7978e436631020f513b25e7
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
System Description: Debian GNU/Linux rodete (upgraded from: Ubuntu 14.04 LTS)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --enable-gcc-warnings=warn-only
 --enable-gtk-deprecation-warnings --without-pop --with-mailutils
 --enable-checking --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''

Configured features:
XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY GNUTLS FREETYPE XFT
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES JSON

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date
mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 95307 7361)
 (symbols 48 20341 1)
 (miscs 40 41 121)
 (strings 32 28343 1417)
 (string-bytes 1 756923)
 (vectors 16 14129)
 (vector-slots 8 499000 10720)
 (floats 8 49 68)
 (intervals 56 225 0)
 (buffers 992 12))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

If you received this communication by mistake, please don’t forward it to
anyone else (it may contain confidential or privileged information), please
erase all copies of it, including all attachments, and please let the sender
know it went to the wrong person.  Thanks.

bug#30031: [PATCH] Inherit query-on-exit flag to stderr process (Bug#30031)

[Philipp Stephani]

* src/process.c (Fmake_process): Have the pipe process honor the
parent's query-on-exit flag.

* test/src/process-tests.el (make-process/noquery-stderr): New test.
---
 src/process.c             |  8 ++++++--
 test/src/process-tests.el | 19 +++++++++++++++++++
 2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/src/process.c b/src/process.c
index d4440e472d..e6465e2347 100644
--- a/src/process.c
+++ b/src/process.c
@@ -1686,6 +1686,8 @@ usage: (make-process &rest ARGS)  */)
   if (!NILP (program))
     CHECK_STRING (program);
 
+  bool query_on_exit = NILP (Fplist_get (contact, QCnoquery));
+
   stderrproc = Qnil;
   xstderr = Fplist_get (contact, QCstderr);
   if (PROCESSP (xstderr))
@@ -1701,7 +1703,9 @@ usage: (make-process &rest ARGS)  */)
 			  QCname,
 			  concat2 (name, build_string (" stderr")),
 			  QCbuffer,
-			  Fget_buffer_create (xstderr));
+			  Fget_buffer_create (xstderr),
+			  QCnoquery,
+			  query_on_exit ? Qnil : Qt);
     }
 
   proc = make_process (name);
@@ -1715,7 +1719,7 @@ usage: (make-process &rest ARGS)  */)
   pset_filter (XPROCESS (proc), Fplist_get (contact, QCfilter));
   pset_command (XPROCESS (proc), Fcopy_sequence (command));
 
-  if (tem = Fplist_get (contact, QCnoquery), !NILP (tem))
+  if (!query_on_exit)
     XPROCESS (proc)->kill_without_query = 1;
   if (tem = Fplist_get (contact, QCstop), !NILP (tem))
     pset_command (XPROCESS (proc), Qt);
diff --git a/test/src/process-tests.el b/test/src/process-tests.el
index 34309a5817..7d35560229 100644
--- a/test/src/process-tests.el
+++ b/test/src/process-tests.el
@@ -162,5 +162,24 @@ process-test-sentinel-wait-function-working-p
                               (error nil))))
     (should (equal path samepath))))
 
+(ert-deftest make-process/noquery-stderr ()
+  "Checks that Bug#30031 is fixed."
+  (skip-unless (executable-find "sleep"))
+  (with-temp-buffer
+    (let* ((previous-processes (process-list))
+           (process (make-process :name "sleep"
+                                  :command '("sleep" "1h")
+                                  :noquery t
+                                  :connection-type 'pipe
+                                  :stderr (current-buffer))))
+      (unwind-protect
+          (let ((new-processes (cl-set-difference (process-list)
+                                                  previous-processes
+                                                  :test #'eq)))
+            (should new-processes)
+            (dolist (process new-processes)
+              (should-not (process-query-on-exit-flag process))))
+        (kill-process process)))))
+
 (provide 'process-tests)
 ;; process-tests.el ends here.
-- 
2.16.0.rc0.223.g4a4ac83678-goog

bug#30031: [PATCH] Inherit query-on-exit flag to stderr process (Bug#30031)

[Noam Postavsky]

found 30031 26.0.90
quit

Philipp Stephani <p.stephani2@gmail.com> writes:

> * src/process.c (Fmake_process): Have the pipe process honor the
> parent's query-on-exit flag.

Looks good to me.  You marked the bug as 27.0.50, but it appears in
26.0.90 as well, and I think this should go to emacs-26.

bug#30031: [PATCH] Inherit query-on-exit flag to stderr process (Bug#30031)

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

Noam Postavsky <npostavs@users.sourceforge.net> schrieb am Mi., 10. Jan.
2018 um 15:36 Uhr:

> found 30031 26.0.90
> quit
>
> Philipp Stephani <p.stephani2@gmail.com> writes:
>
> > * src/process.c (Fmake_process): Have the pipe process honor the
> > parent's query-on-exit flag.
>
> Looks good to me.  You marked the bug as 27.0.50, but it appears in
> 26.0.90 as well, and I think this should go to emacs-26.
>

Pushed to emacs-26 as  9c2b11484f.

[-- Attachment #2: Type: text/html, Size: 838 bytes --]