bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Artem Loenko via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 2081 bytes --]

Hello there,

Emacs master (as of 8bc727d0b4 "Fix the recent `length' doc string addition" commit) does not compile on Apple Silicon (M1) anymore. Compilation fails with the following error:

./temacs --batch  -l loadup --temacs=pbootstrap
make[1]: *** [bootstrap-emacs.pdmp] Killed: 9
make: *** [src] Error 2

When you try to run the `temacs` under lldb, it shows the following problem:

(lldb) process launch
Process 75320 launched: '/Users/dive/Projects/emacs/src/temacs' (arm64)
Loading loadup.el (source)...
...
Eager macro-expansion failure: (void-variable search-slow-speed)
Eager macro-expansion failure: (void-variable search-slow-speed)
Symbol’s value as variable is void: search-slow-speed
Process 75320 exited with status = 255 (0x000000ff) 

The problem was introduced in the "Merge from origin/emacs-27” commit – https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=90ec81f5b243b6b7b3ebe2de394b20e8078ebc96 and I believe it was unintentional revert of DO_CODESIGN within src/Makefile.in:

diff --git a/src/Makefile.in b/src/Makefile.in
index 39c0f12fe6..19304cca04 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -338,7 +338,7 @@ HAVE_PDUMPER = @HAVE_PDUMPER@
 
 ## ARM Macs require that all code have a valid signature.  Since pump
 ## invalidates the signature, we must re-sign to fix it.
-DO_CODESIGN=$(patsubst aarch64-apple-darwin%,yes,@configuration@)
+DO_CODESIGN=$(patsubst arm-apple-darwin%,yes,@configuration@)

The following patch reverts the change and fixes the problem:

diff --git a/src/Makefile.in b/src/Makefile.in
index 19304cca04..39c0f12fe6 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -338,7 +338,7 @@ HAVE_PDUMPER =
 
 ## ARM Macs require that all code have a valid signature.  Since pump
 ## invalidates the signature, we must re-sign to fix it.
-DO_CODESIGN=$(patsubst arm-apple-darwin%,yes,@configuration@)
+DO_CODESIGN=$(patsubst aarch64-apple-darwin%,yes,@configuration@)
 
 # 'make' verbosity.
 AM_DEFAULT_VERBOSITY = @AM_DEFAULT_VERBOSITY@

Regards,
Artem Loenko


[-- Attachment #2: path_do_codesign.patch --]
[-- Type: application/octet-stream, Size: 493 bytes --]

diff --git a/src/Makefile.in b/src/Makefile.in
index 19304cca04..39c0f12fe6 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -338,7 +338,7 @@ HAVE_PDUMPER =
 
 ## ARM Macs require that all code have a valid signature.  Since pump
 ## invalidates the signature, we must re-sign to fix it.
-DO_CODESIGN=$(patsubst arm-apple-darwin%,yes,@configuration@)
+DO_CODESIGN=$(patsubst aarch64-apple-darwin%,yes,@configuration@)
 
 # 'make' verbosity.
 AM_DEFAULT_VERBOSITY = @AM_DEFAULT_VERBOSITY@

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Philipp Stephani]

Am So., 27. Dez. 2020 um 12:54 Uhr schrieb Artem Loenko via Bug
reports for GNU Emacs, the Swiss army knife of text editors
<bug-gnu-emacs@gnu.org>:
>
> Hello there,
>
> Emacs master (as of 8bc727d0b4 "Fix the recent `length' doc string addition" commit) does not compile on Apple Silicon (M1) anymore. Compilation fails with the following error:
>
> ./temacs --batch  -l loadup --temacs=pbootstrap
> make[1]: *** [bootstrap-emacs.pdmp] Killed: 9
> make: *** [src] Error 2
>
> When you try to run the `temacs` under lldb, it shows the following problem:
>
> (lldb) process launch
> Process 75320 launched: '/Users/dive/Projects/emacs/src/temacs' (arm64)
> Loading loadup.el (source)...
> ...
> Eager macro-expansion failure: (void-variable search-slow-speed)
> Eager macro-expansion failure: (void-variable search-slow-speed)
> Symbol’s value as variable is void: search-slow-speed
> Process 75320 exited with status = 255 (0x000000ff)
>
> The problem was introduced in the "Merge from origin/emacs-27” commit – https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=90ec81f5b243b6b7b3ebe2de394b20e8078ebc96 and I believe it was unintentional revert of DO_CODESIGN within src/Makefile.in:
>
> diff --git a/src/Makefile.in b/src/Makefile.in
> index 39c0f12fe6..19304cca04 100644
> --- a/src/Makefile.in
> +++ b/src/Makefile.in
> @@ -338,7 +338,7 @@ HAVE_PDUMPER = @HAVE_PDUMPER@
>
>  ## ARM Macs require that all code have a valid signature.  Since pump
>  ## invalidates the signature, we must re-sign to fix it.
> -DO_CODESIGN=$(patsubst aarch64-apple-darwin%,yes,@configuration@)
> +DO_CODESIGN=$(patsubst arm-apple-darwin%,yes,@configuration@)

For some reason the @configuration@ value on my system is occasionally
either arm-... or aarch64-..., without a clear pattern. Should we
maybe accept both? Or can we make sure that aarch64-... is detected
consistently?

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Artem Loenko via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Looks strange indeed. 

I see that these changes were introduced in this commit – https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-27&id=fda9b3e83a434706c31ab1bee5c15511c0181d5a So, emacs-27 branch does not compile on Apple Silicon as well any more. Also, I believe, it should be at least `arm64-apple-darwin` and not `arm-apple-darwin`. Though, I tried to compile with `arm64-apple-darwin` but got the same error with `temacs`.

I checked LLVM bundled with Xcode 12.3 and LLVM 11.0.0. Both report `arm64-apple-darwin` as a target (the same for `-print-effective-triple`:

> ~/Projects/emacs $ /opt/homebrew/opt/llvm/bin/clang --version
> clang version 11.0.0
> Target: arm64-apple-darwin20.2.0
> Thread model: posix
> InstalledDir: /opt/homebrew/opt/llvm/bin

> ~/Projects/emacs $ xcrun clang --version
> Apple clang version 12.0.0 (clang-1200.0.32.28)
> Target: arm64-apple-darwin20.2.0
> Thread model: posix
> InstalledDir: /Volumes/Extended/Archives/Xcode_12.3.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Though, during the ./configure, `config.guess` identifies the system as `aarch64-apple-darwin`:

> Running ./configure ...
> ./configure
> ...
> checking build system type... aarch64-apple-darwin20.2.0
> checking host system type... aarch64-apple-darwin20.2.0
> …
> Configured for 'aarch64-apple-darwin20.2.0’.

> ~/Projects/emacs $ ./build-aux/config.guess
> aarch64-apple-darwin20.2.0

It seems that `clang` is good with both versions as a target.

Anyway, the fact is that `temacs` works fine with `aarch64-apple-darwin` target and does not with `arm(64)-apple-darwin`. I do not know much about `temacs` and Emacs internals, if you have any leads or theories to check – let me know, I will try my best. So far, my best idea is that we propagate the target to other tool that does not “understand” `arm64-apple-darwin`.

Regards,
Artem Loenko

> On 27 Dec 2020, at 14:12, Philipp Stephani <p.stephani2@gmail.com> wrote:
> 
> Am So., 27. Dez. 2020 um 12:54 Uhr schrieb Artem Loenko via Bug
> reports for GNU Emacs, the Swiss army knife of text editors
> <bug-gnu-emacs@gnu.org>:
>> 
>> Hello there,
>> 
>> Emacs master (as of 8bc727d0b4 "Fix the recent `length' doc string addition" commit) does not compile on Apple Silicon (M1) anymore. Compilation fails with the following error:
>> 
>> ./temacs --batch  -l loadup --temacs=pbootstrap
>> make[1]: *** [bootstrap-emacs.pdmp] Killed: 9
>> make: *** [src] Error 2
>> 
>> When you try to run the `temacs` under lldb, it shows the following problem:
>> 
>> (lldb) process launch
>> Process 75320 launched: '/Users/dive/Projects/emacs/src/temacs' (arm64)
>> Loading loadup.el (source)...
>> ...
>> Eager macro-expansion failure: (void-variable search-slow-speed)
>> Eager macro-expansion failure: (void-variable search-slow-speed)
>> Symbol’s value as variable is void: search-slow-speed
>> Process 75320 exited with status = 255 (0x000000ff)
>> 
>> The problem was introduced in the "Merge from origin/emacs-27” commit – https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=90ec81f5b243b6b7b3ebe2de394b20e8078ebc96 and I believe it was unintentional revert of DO_CODESIGN within src/Makefile.in:
>> 
>> diff --git a/src/Makefile.in b/src/Makefile.in
>> index 39c0f12fe6..19304cca04 100644
>> --- a/src/Makefile.in
>> +++ b/src/Makefile.in
>> @@ -338,7 +338,7 @@ HAVE_PDUMPER = @HAVE_PDUMPER@
>> 
>> ## ARM Macs require that all code have a valid signature.  Since pump
>> ## invalidates the signature, we must re-sign to fix it.
>> -DO_CODESIGN=$(patsubst aarch64-apple-darwin%,yes,@configuration@)
>> +DO_CODESIGN=$(patsubst arm-apple-darwin%,yes,@configuration@)
> 
> For some reason the @configuration@ value on my system is occasionally
> either arm-... or aarch64-..., without a clear pattern. Should we
> maybe accept both? Or can we make sure that aarch64-... is detected
> consistently?

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Philipp Stephani]

Am So., 27. Dez. 2020 um 21:12 Uhr schrieb Artem Loenko <artyom.loenko@mac.com>:
>
> Looks strange indeed.
>
> I see that these changes were introduced in this commit – https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-27&id=fda9b3e83a434706c31ab1bee5c15511c0181d5a So, emacs-27 branch does not compile on Apple Silicon as well any more. Also, I believe, it should be at least `arm64-apple-darwin` and not `arm-apple-darwin`. Though, I tried to compile with `arm64-apple-darwin` but got the same error with `temacs`.

I'd agree, but then, the src/Makefile for my emacs-27 worktree has

DO_CODESIGN=$(patsubst arm-apple-darwin%,yes,arm-apple-darwin20.2.0)

indicating that at least here the architecture was detected as
arm-apple-darwin20.2.0. On master it's aarch64-apple-darwin20.2.0 for
me as well.

>
> I checked LLVM bundled with Xcode 12.3 and LLVM 11.0.0. Both report `arm64-apple-darwin` as a target (the same for `-print-effective-triple`:
>
> > ~/Projects/emacs $ /opt/homebrew/opt/llvm/bin/clang --version
> > clang version 11.0.0
> > Target: arm64-apple-darwin20.2.0
> > Thread model: posix
> > InstalledDir: /opt/homebrew/opt/llvm/bin
>
> > ~/Projects/emacs $ xcrun clang --version
> > Apple clang version 12.0.0 (clang-1200.0.32.28)
> > Target: arm64-apple-darwin20.2.0
> > Thread model: posix
> > InstalledDir: /Volumes/Extended/Archives/Xcode_12.3.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
>
> Though, during the ./configure, `config.guess` identifies the system as `aarch64-apple-darwin`:
>
> > Running ./configure ...
> > ./configure
> > ...
> > checking build system type... aarch64-apple-darwin20.2.0
> > checking host system type... aarch64-apple-darwin20.2.0
> > …
> > Configured for 'aarch64-apple-darwin20.2.0’.
>
> > ~/Projects/emacs $ ./build-aux/config.guess
> > aarch64-apple-darwin20.2.0
>
> It seems that `clang` is good with both versions as a target.
>
> Anyway, the fact is that `temacs` works fine with `aarch64-apple-darwin` target and does not with `arm(64)-apple-darwin`. I do not know much about `temacs` and Emacs internals, if you have any leads or theories to check – let me know, I will try my best. So far, my best idea is that we propagate the target to other tool that does not “understand” `arm64-apple-darwin`.

IIUC the only thing that this line does is to check whether to
codesign the resulting binary. That's necessary on Apple Silicon.
Maybe we should codesign on all macOS installations? It shouldn't hurt
even if it's not needed.

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Artem Loenko via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 2433 bytes --]

> DO_CODESIGN=$(patsubst arm-apple-darwin%,yes,arm-apple-darwin20.2.0)
> 
> indicating that at least here the architecture was detected as
> arm-apple-darwin20.2.0. On master it's aarch64-apple-darwin20.2.0 for
> me as well.

I believe that you see `arm-apple-darwin` in the emacs-27 branch because aarch64 support was incorporated only for Emacs master branch and was not backported. There is a commit – https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5d89a9c2846d32b4726faaf5c8652f3f23dc7d73 <https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5d89a9c2846d32b4726faaf5c8652f3f23dc7d73> with the following changes in the master:

diff --git a/build-aux/config.guess b/build-aux/config.guess
index 92bfc33e29..e94095c5fb 100755
--- a/build-aux/config.guess
+++ b/build-aux/config.guess
@@ -2,7 +2,7 @@
 # Attempt to guess a canonical system name.
 #   Copyright 1992-2020 Free Software Foundation, Inc.
 
-timestamp='2020-04-26'
+timestamp='2020-07-12'
 
 # This file is free software; you can redistribute it and/or modify it
 # under the terms of the GNU General Public License as published by
@@ -1342,6 +1342,9 @@ EOF
     *:Rhapsody:*:*)
 	echo "$UNAME_MACHINE"-apple-rhapsody"$UNAME_RELEASE"
 	exit ;;
+    arm64:Darwin:*:*)
+	echo aarch64-apple-darwin"$UNAME_RELEASE"
+	exit ;;
     *:Darwin:*:*)
 	UNAME_PROCESSOR=`uname -p`
 	case $UNAME_PROCESSOR in

But in the `emacs-27` branch it calculates with a simple `uname -r` – to the `arm-apple-darwin` (I was able to reproduce it locally on the `emacs-27` branch).

> IIUC the only thing that this line does is to check whether to
> codesign the resulting binary. That's necessary on Apple Silicon.
> Maybe we should codesign on all macOS installations? It shouldn't hurt
> even if it's not needed.

Yes, you are right. The problem has nothing to do with `temacs`; it is about signing. I tried to call `codesign` explicitly, and everything works fine in this case. About codesigning for all macOS installations, I am not sure. Such change can break things in many unexpected ways from my point of view. It is better to stay on the safe side.

I see two options:

- Backport `arm64:Darwin:*:*)` support within `config.guess` to emacs-27 branch and switch to `aarch64-apple-darwin` everywhere
- Do not backport, but switch to `aarch64-apple-darwin` everywhere anyway :)

What do you think?

Regards,
Artem Loenko


[-- Attachment #2: Type: text/html, Size: 5267 bytes --]

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Eli Zaretskii]

> Date: Sun, 27 Dec 2020 21:37:23 +0000
> Cc: 45455@debbugs.gnu.org
> From: Artem Loenko via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> I see two options:
> 
> - Backport `arm64:Darwin:*:*)` support within `config.guess` to emacs-27 branch and switch to
> `aarch64-apple-darwin` everywhere
> - Do not backport, but switch to `aarch64-apple-darwin` everywhere anyway :)
> 
> What do you think?

The latter, please.  It's too late to backport config.guess to the
release branch, and I see no good reason to do so.

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Artem Loenko via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]

> On 28 Dec 2020, at 03:27, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> Date: Sun, 27 Dec 2020 21:37:23 +0000
>> Cc: 45455@debbugs.gnu.org
>> From: Artem Loenko via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>> 
>> I see two options:
>> 
>> - Backport `arm64:Darwin:*:*)` support within `config.guess` to emacs-27 branch and switch to
>> `aarch64-apple-darwin` everywhere
>> - Do not backport, but switch to `aarch64-apple-darwin` everywhere anyway :)
>> 
>> What do you think?
> 
> The latter, please.  It's too late to backport config.guess to the
> release branch, and I see no good reason to do so.

Then the patch in the initial message will do. We have to apply it to the master and emacs-27 (if there will be more releases from it) branches. I just checked, Emacs compiles fine on both branches with the patch on Apple Silicon. Or we can revert the following commit – https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-27&id=fda9b3e83a434706c31ab1bee5c15511c0181d5a <https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-27&id=fda9b3e83a434706c31ab1bee5c15511c0181d5a>

Philipp, are okay with this?

[-- Attachment #2: Type: text/html, Size: 2027 bytes --]

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Philipp Stephani]

Am Mo., 28. Dez. 2020 um 12:07 Uhr schrieb Artem Loenko <artyom.loenko@mac.com>:
>
> On 28 Dec 2020, at 03:27, Eli Zaretskii <eliz@gnu.org> wrote:
>
>
> Date: Sun, 27 Dec 2020 21:37:23 +0000
> Cc: 45455@debbugs.gnu.org
> From: Artem Loenko via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> I see two options:
>
> - Backport `arm64:Darwin:*:*)` support within `config.guess` to emacs-27 branch and switch to
> `aarch64-apple-darwin` everywhere
> - Do not backport, but switch to `aarch64-apple-darwin` everywhere anyway :)
>
> What do you think?
>
>
> The latter, please.  It's too late to backport config.guess to the
> release branch, and I see no good reason to do so.
>
>
> Then the patch in the initial message will do. We have to apply it to the master and emacs-27 (if there will be more releases from it) branches. I just checked, Emacs compiles fine on both branches with the patch on Apple Silicon. Or we can revert the following commit – https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-27&id=fda9b3e83a434706c31ab1bee5c15511c0181d5a

I installed that commit because without it, building the emacs-27
branch doesn't work on my system (due to the architecture mismatch).
Why do you think that reverting it won't break the build again?

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Artem Loenko via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> On 28 Dec 2020, at 11:11, Philipp Stephani <p.stephani2@gmail.com> wrote:
> 
> I installed that commit because without it, building the emacs-27
> branch doesn't work on my system (due to the architecture mismatch).
> Why do you think that reverting it won't break the build again?

I made a mistake and checked on the tagged version, not on the emacs-27 branch itself. I double-checked, and you are right. It will break the emacs-27 as you said. Sorry for the confusion.

This is the Makefile on the emacs-27 branch with the patch, and it will not fly:

./src/Makefile
...
DO_CODESIGN=$(patsubst aarch64-apple-darwin%,yes,arm-apple-darwin20.2.0)

So, we need the patch only on the master, considering these recent changes in the `config.quess`.

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Philipp Stephani]

Am Mo., 28. Dez. 2020 um 12:42 Uhr schrieb Artem Loenko <artyom.loenko@mac.com>:
>
> > On 28 Dec 2020, at 11:11, Philipp Stephani <p.stephani2@gmail.com> wrote:
> >
> > I installed that commit because without it, building the emacs-27
> > branch doesn't work on my system (due to the architecture mismatch).
> > Why do you think that reverting it won't break the build again?
>
> I made a mistake and checked on the tagged version, not on the emacs-27 branch itself. I double-checked, and you are right. It will break the emacs-27 as you said. Sorry for the confusion.
>
> This is the Makefile on the emacs-27 branch with the patch, and it will not fly:
>
> ./src/Makefile
> ...
> DO_CODESIGN=$(patsubst aarch64-apple-darwin%,yes,arm-apple-darwin20.2.0)
>
> So, we need the patch only on the master, considering these recent changes in the `config.quess`.

SGTM, thanks!

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Artem Loenko via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> On 28 Dec 2020, at 11:44, Philipp Stephani <p.stephani2@gmail.com> wrote:
> 
> Am Mo., 28. Dez. 2020 um 12:42 Uhr schrieb Artem Loenko <artyom.loenko@mac.com>:
>> 
>> I made a mistake and checked on the tagged version, not on the emacs-27 branch itself. I double-checked, and you are right. It will break the emacs-27 as you said. Sorry for the confusion.
>> 
>> This is the Makefile on the emacs-27 branch with the patch, and it will not fly:
>> 
>> ./src/Makefile
>> ...
>> DO_CODESIGN=$(patsubst aarch64-apple-darwin%,yes,arm-apple-darwin20.2.0)
>> 
>> So, we need the patch only on the master, considering these recent changes in the `config.quess`.
> 
> SGTM, thanks!

Any chance someone can merge the patch into the master branch? Thanks!

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Philipp Stephani]

Am Di., 29. Dez. 2020 um 20:26 Uhr schrieb Artem Loenko <artyom.loenko@mac.com>:
>
> > On 28 Dec 2020, at 11:44, Philipp Stephani <p.stephani2@gmail.com> wrote:
> >
> > Am Mo., 28. Dez. 2020 um 12:42 Uhr schrieb Artem Loenko <artyom.loenko@mac.com>:
> >>
> >> I made a mistake and checked on the tagged version, not on the emacs-27 branch itself. I double-checked, and you are right. It will break the emacs-27 as you said. Sorry for the confusion.
> >>
> >> This is the Makefile on the emacs-27 branch with the patch, and it will not fly:
> >>
> >> ./src/Makefile
> >> ...
> >> DO_CODESIGN=$(patsubst aarch64-apple-darwin%,yes,arm-apple-darwin20.2.0)
> >>
> >> So, we need the patch only on the master, considering these recent changes in the `config.quess`.
> >
> > SGTM, thanks!
>
> Any chance someone can merge the patch into the master branch? Thanks!

Done.

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Artem Loenko via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> On 29 Dec 2020, at 19:45, Philipp Stephani <p.stephani2@gmail.com> wrote:
> 
> Am Di., 29. Dez. 2020 um 20:26 Uhr schrieb Artem Loenko <artyom.loenko@mac.com>:
>> 
>>> On 28 Dec 2020, at 11:44, Philipp Stephani <p.stephani2@gmail.com> wrote:
>>> 
>>> Am Mo., 28. Dez. 2020 um 12:42 Uhr schrieb Artem Loenko <artyom.loenko@mac.com>:
>>>> 
>>>> I made a mistake and checked on the tagged version, not on the emacs-27 branch itself. I double-checked, and you are right. It will break the emacs-27 as you said. Sorry for the confusion.
>>>> 
>>>> This is the Makefile on the emacs-27 branch with the patch, and it will not fly:
>>>> 
>>>> ./src/Makefile
>>>> ...
>>>> DO_CODESIGN=$(patsubst aarch64-apple-darwin%,yes,arm-apple-darwin20.2.0)
>>>> 
>>>> So, we need the patch only on the master, considering these recent changes in the `config.quess`.
>>> 
>>> SGTM, thanks!
>> 
>> Any chance someone can merge the patch into the master branch? Thanks!
> 
> Done.

Thanks! Perhaps, we can close the bug report as well – https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45455

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Lars Ingebrigtsen]

Artem Loenko via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> Thanks! Perhaps, we can close the bug report as well –
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45455

Sure; done.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#45455: [nextstep]: Emacs master does not compile on Apple Silicon (arm64)

[Philipp Stephani]

Am So., 27. Dez. 2020 um 22:37 Uhr schrieb Artem Loenko <artyom.loenko@mac.com>:

> I see two options:
>
> - Backport `arm64:Darwin:*:*)` support within `config.guess` to emacs-27 branch and switch to `aarch64-apple-darwin` everywhere
> - Do not backport, but switch to `aarch64-apple-darwin` everywhere anyway :)
>
> What do you think?


Wouldn't the second option break compilation on Emacs 27? If so, I'd
say that's a non-starter.
Why not leave the emacs-27 branch alone, and only fix the build on the
master branch?