* bug#14930: 24.3.50; Reverting process list fails after list-packages
@ 2013-07-22 11:13 Ari Roponen
2013-07-22 11:40 ` Juanma Barranquero
0 siblings, 1 reply; 2+ messages in thread
From: Ari Roponen @ 2013-07-22 11:13 UTC (permalink / raw)
To: 14930
Starting from emacs -Q:
M-x list-packages
M-x list-processes
C-x o ; Switch to the process list.
g ; Revert buffer.
=> apply: Args out of range: [("ack" face link follow-link t package-desc ...
This happens because `package-mode-menu' adds a revert function to
`tabulated-list-revert-hook' globally, and reverting process list
tries to run it.
The following patch fixes the problem by adding the function to the hook
locally.
2013-07-22 Ari Roponen <ari.roponen@gmail.com>
* emacs-lisp/package.el (package-menu-mode): Don't modify the
global value of tabulated-list-revert-hook.
=== modified file 'lisp/emacs-lisp/package.el'
--- lisp/emacs-lisp/package.el 2013-06-26 00:44:35 +0000
+++ lisp/emacs-lisp/package.el 2013-07-22 09:56:00 +0000
@@ -1393,7 +1393,7 @@
("Description" 0 nil)])
(setq tabulated-list-padding 2)
(setq tabulated-list-sort-key (cons "Status" nil))
- (add-hook 'tabulated-list-revert-hook 'package-menu--refresh)
+ (add-hook 'tabulated-list-revert-hook 'package-menu--refresh nil t)
(tabulated-list-init-header))
(defmacro package--push (pkg-desc status listname)
In GNU Emacs 24.3.50.6 (x86_64-unknown-linux-gnu, GTK+ Version 3.9.8)
of 2013-07-22 on arirop
Bzr revision: 113489 rgm@gnu.org-20130722102102-t430il8zjpfasx60
--
Ari Roponen
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#14930: 24.3.50; Reverting process list fails after list-packages
2013-07-22 11:13 bug#14930: 24.3.50; Reverting process list fails after list-packages Ari Roponen
@ 2013-07-22 11:40 ` Juanma Barranquero
0 siblings, 0 replies; 2+ messages in thread
From: Juanma Barranquero @ 2013-07-22 11:40 UTC (permalink / raw)
To: Ari Roponen; +Cc: 14930-done
On Mon, Jul 22, 2013 at 1:13 PM, Ari Roponen <ari.roponen@gmail.com> wrote:
> 2013-07-22 Ari Roponen <ari.roponen@gmail.com>
>
> * emacs-lisp/package.el (package-menu-mode): Don't modify the
> global value of tabulated-list-revert-hook.
Thanks, committed as revno:113490.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-22 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-22 11:13 bug#14930: 24.3.50; Reverting process list fails after list-packages Ari Roponen
2013-07-22 11:40 ` Juanma Barranquero
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).