unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 59710-done@debbugs.gnu.org
Subject: bug#59710: Wrong type argument when editing a multisession variable
Date: Fri, 2 Dec 2022 14:30:52 +0100	[thread overview]
Message-ID: <CAAeL0SR9Vp+3TKCcZVTNERk6n2cJvvDOHZKnD1VcdOoQ=eLrmg@mail.gmail.com> (raw)
In-Reply-To: <83mt86eyyx.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

On Fri, Dec 2, 2022 at 2:07 PM Eli Zaretskii <eliz@gnu.org> wrote:

> This makes sense to me, so please go ahead and install (assuming that the
> multisession tests still all pass after this change).

Yes, they pass. Installed in commit e5b0141b0d of 2022-12-02.

BTW, I wonder if it would make sense to make bound-and-true-p to check that
it gets a symbol:

diff --git i/lisp/bindings.el w/lisp/bindings.el
index c1ad5f7520..6ee730af58 100644
--- i/lisp/bindings.el
+++ w/lisp/bindings.el
@@ -671,4 +671,6 @@ bound-and-true-p
 Note that if `lexical-binding' is in effect, this function isn't
 meaningful if it refers to a lexically bound variable."
+  (unless (symbolp var)
+    (error "Wrong type argument: symbolp, %S" var))
   `(and (boundp (quote ,var)) ,var))

[-- Attachment #2: Type: text/html, Size: 1246 bytes --]

  reply	other threads:[~2022-12-02 13:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30  1:49 bug#59710: Wrong type argument when editing a multisession variable Juanma Barranquero
2022-12-02 13:07 ` Eli Zaretskii
2022-12-02 13:30   ` Juanma Barranquero [this message]
2022-12-02 15:06     ` Eli Zaretskii
2022-12-02 15:40       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-03  0:25         ` Juanma Barranquero
2022-12-03  0:28           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAeL0SR9Vp+3TKCcZVTNERk6n2cJvvDOHZKnD1VcdOoQ=eLrmg@mail.gmail.com' \
    --to=lekktu@gmail.com \
    --cc=59710-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).