From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#59710: Wrong type argument when editing a multisession variable Date: Fri, 2 Dec 2022 14:30:52 +0100 Message-ID: References: <83mt86eyyx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000f8527205eed85add" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13404"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 59710-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 14:33:07 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p16A7-0003Kd-R9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 14:33:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p169c-0007DS-V0; Fri, 02 Dec 2022 08:32:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1695-00078d-3C for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 08:32:11 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1694-0006ud-8D for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 08:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1693-0005UG-W8 for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 08:32:02 -0500 Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 13:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59710 X-GNU-PR-Package: emacs Mail-Followup-To: 59710@debbugs.gnu.org, lekktu@gmail.com, lekktu@gmail.com Original-Received: via spool by 59710-done@debbugs.gnu.org id=D59710.166998790221081 (code D ref 59710); Fri, 02 Dec 2022 13:32:01 +0000 Original-Received: (at 59710-done) by debbugs.gnu.org; 2 Dec 2022 13:31:42 +0000 Original-Received: from localhost ([127.0.0.1]:46749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p168j-0005Tx-HL for submit@debbugs.gnu.org; Fri, 02 Dec 2022 08:31:41 -0500 Original-Received: from mail-ej1-f45.google.com ([209.85.218.45]:39688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p168e-0005Tr-Vm for 59710-done@debbugs.gnu.org; Fri, 02 Dec 2022 08:31:39 -0500 Original-Received: by mail-ej1-f45.google.com with SMTP id ml11so11579721ejb.6 for <59710-done@debbugs.gnu.org>; Fri, 02 Dec 2022 05:31:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MQU+Dy7D0zRSCEe8Mx/lvt4AbnY8wbtmHR+VLaG/bz4=; b=U/CCqvwkdpjBQLNTSsB0vCy7n9ycziROENlxxT38HwBLaCbnR4nbdzJGGgSWHemRrY gRtVVD9lK7U0mK6lnz5QW8BvzicVyQgeW+p7DnQGrle/o0ak6gfhsInKgotU+i5+RVcX xJQAftL4PNNsea4Sr5zYmyqLPo1rtOw/bvM6NvdZj5olhmM67d7JfDAwZ14oxMoiZFgN w2BD2MDkpheWpraPIO84IBTSSBRPVLeNKirgiLjKAuc/MQRj0uu0x1Uc0B8yC6MWjf4w 5glIu9GYkEQOzLuTOV0A9MJmLPZ/zCpzxBtYv1XlpH2z4clV2rWLzT5aRm9G5FaijX7D tXPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MQU+Dy7D0zRSCEe8Mx/lvt4AbnY8wbtmHR+VLaG/bz4=; b=M5KhOXSa96zVb9qs06hzksnA7hJM4uJFQUzqZnNht7lYdPKFdAos6hy1okskSQJMAi AjkCAoFz7kg/xoAGrvHIDhwu97dRmSwqGNfYLtklgG4noDDehnJF9p/LcnEO7pPEIGqR STfS9w3ZA3UeUpWKpbDcvvaJlxWUcFVg2RcQRerYNrK0rNg8cQU0gHo48eI0vZwfaQSa Gzy9EEWNymo+PkabWS/BOyYv4nHREUaeXYSgMgI21HjJPrEIWYOWV2JWF65rL4NojbNk NinqAdvsFqW68G72PY0TN8SNCd76kOU73h+SpI/AJmroLc8bq4/32pSij9x0fgzpK861 N62w== X-Gm-Message-State: ANoB5pkcARasv8KCH24yWH0c1Z4GvX/b9r0en4obXtcKGnptl490CKkc dYBBS3UnE0uJPPFQpPt+JbIo+MBuUszCxCtQzmg= X-Google-Smtp-Source: AA0mqf4eMoASnrsey0QTKq+dUOkDAiJYqs9v+uMpSLM2Fw8qIMUU3DRPSdt/8g7RO5FkmXAXZWUZBAmCVKk37g+jqlQ= X-Received: by 2002:a17:906:a991:b0:7ba:85a7:2ec3 with SMTP id jr17-20020a170906a99100b007ba85a72ec3mr37630133ejb.36.1669987890121; Fri, 02 Dec 2022 05:31:30 -0800 (PST) In-Reply-To: <83mt86eyyx.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249741 Archived-At: --000000000000f8527205eed85add Content-Type: text/plain; charset="UTF-8" On Fri, Dec 2, 2022 at 2:07 PM Eli Zaretskii wrote: > This makes sense to me, so please go ahead and install (assuming that the > multisession tests still all pass after this change). Yes, they pass. Installed in commit e5b0141b0d of 2022-12-02. BTW, I wonder if it would make sense to make bound-and-true-p to check that it gets a symbol: diff --git i/lisp/bindings.el w/lisp/bindings.el index c1ad5f7520..6ee730af58 100644 --- i/lisp/bindings.el +++ w/lisp/bindings.el @@ -671,4 +671,6 @@ bound-and-true-p Note that if `lexical-binding' is in effect, this function isn't meaningful if it refers to a lexically bound variable." + (unless (symbolp var) + (error "Wrong type argument: symbolp, %S" var)) `(and (boundp (quote ,var)) ,var)) --000000000000f8527205eed85add Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Fri, Dec 2, 2022 at 2:07 PM Eli Zar= etskii <eliz@gnu.org> wrote:
> This makes sense to me, so please go ahead and install (assuming = that the
> multisession tests still all pass after this change).
<= br>
Yes, they pass. Installed in commit e5b0141b0d of 2022-12-02.
BTW, I wonder if it would make sense to = make bound-and-true-p to check that it gets a symbol:

diff --git i/lisp/bindings.el w/lisp/bindings.el
index= c1ad5f7520..6ee730af58 100644
--- i/lisp/bindings.el
+++ w/lisp/bind= ings.el
@@ -671,4 +671,6 @@ bound-and-true-p
=C2=A0Note that if `lexi= cal-binding' is in effect, this function isn't
=C2=A0meaningful = if it refers to a lexically bound variable."
+ =C2=A0(unless (symbo= lp var)
+ =C2=A0 =C2=A0(error "Wrong type argument: symbolp, %S&quo= t; var))
=C2=A0 =C2=A0`(and (boundp (quote ,var)) ,var))
=C2=A0

--000000000000f8527205eed85add--