* bug#15009: cl-lib symbols in lisp-font-lock-keywords
@ 2013-08-02 16:31 Juanma Barranquero
2013-08-02 16:40 ` Glenn Morris
2013-08-02 17:16 ` Stefan Monnier
0 siblings, 2 replies; 6+ messages in thread
From: Juanma Barranquero @ 2013-08-02 16:31 UTC (permalink / raw)
To: 15009
Package: emacs
Version: 24.3.50
Now that cl-lib is the preferred way to use CL, cl-lib symbols like
cl-defun, cl-loop. cl-defstruct, etc.
should be added to lisp-font-lock-keywords-*.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#15009: cl-lib symbols in lisp-font-lock-keywords
2013-08-02 16:31 bug#15009: cl-lib symbols in lisp-font-lock-keywords Juanma Barranquero
@ 2013-08-02 16:40 ` Glenn Morris
2013-08-02 17:05 ` bug#12761: " Juanma Barranquero
2013-08-02 17:16 ` Stefan Monnier
1 sibling, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2013-08-02 16:40 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: 15009
Dupe of http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12761
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#12761: bug#15009: cl-lib symbols in lisp-font-lock-keywords
2013-08-02 16:40 ` Glenn Morris
@ 2013-08-02 17:05 ` Juanma Barranquero
0 siblings, 0 replies; 6+ messages in thread
From: Juanma Barranquero @ 2013-08-02 17:05 UTC (permalink / raw)
To: Glenn Morris; +Cc: 12761
> Dupe of http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12761
Oops, sorry.
Anyway, I see there was mild consensus but then things stalled.
Christopher Schmidt's add-cl-font-lock-keywords is a good start but it
just font-locks the keyword, not the name for cl-defun, etc.
We should go forward with some fix, because there are currently ~90
uses of cl-defstruct/cl-defun in the lisp sources, and the number will
likely go up.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#15009: cl-lib symbols in lisp-font-lock-keywords
2013-08-02 16:31 bug#15009: cl-lib symbols in lisp-font-lock-keywords Juanma Barranquero
2013-08-02 16:40 ` Glenn Morris
@ 2013-08-02 17:16 ` Stefan Monnier
2013-08-02 17:26 ` Juanma Barranquero
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2013-08-02 17:16 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: 15009
> Now that cl-lib is the preferred way to use CL, cl-lib symbols like
> cl-defun, cl-loop. cl-defstruct, etc.
> should be added to lisp-font-lock-keywords-*.
Right.
But: these are not valid in Lisp. So we need to clean this up by
splitting lisp-font-lock-keywords into a "Lisp" part and an
"Elisp" part.
BTW, ideally, these keyword faces would be added by dynamically
collecting the set of known macros, rather than by a hardcoded list.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#15009: cl-lib symbols in lisp-font-lock-keywords
2013-08-02 17:16 ` Stefan Monnier
@ 2013-08-02 17:26 ` Juanma Barranquero
2013-08-02 19:23 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Juanma Barranquero @ 2013-08-02 17:26 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 15009
On Fri, Aug 2, 2013 at 7:16 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> But: these are not valid in Lisp. So we need to clean this up by
> splitting lisp-font-lock-keywords into a "Lisp" part and an
> "Elisp" part.
OK.
> BTW, ideally, these keyword faces would be added by dynamically
> collecting the set of known macros, rather than by a hardcoded list.
Why? It is a restricted and well-defined set, unlikely to change.
Adding them dynamically adds unnecessary complexity IMO.
J
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#15009: cl-lib symbols in lisp-font-lock-keywords
2013-08-02 17:26 ` Juanma Barranquero
@ 2013-08-02 19:23 ` Stefan Monnier
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2013-08-02 19:23 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: 15009
>> BTW, ideally, these keyword faces would be added by dynamically
>> collecting the set of known macros, rather than by a hardcoded list.
> Why? It is a restricted and well-defined set, unlikely to change.
> Adding them dynamically adds unnecessary complexity IMO.
In order to highlight the name of things defined with cl-defun and
friends, I agree. But the part that highlights `cl-destructuring-bind'
in font-lock-keyword-face should do it based on the fact that
cl-destructuring-bind is a macro, not via some hard-coded list.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-02 19:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-02 16:31 bug#15009: cl-lib symbols in lisp-font-lock-keywords Juanma Barranquero
2013-08-02 16:40 ` Glenn Morris
2013-08-02 17:05 ` bug#12761: " Juanma Barranquero
2013-08-02 17:16 ` Stefan Monnier
2013-08-02 17:26 ` Juanma Barranquero
2013-08-02 19:23 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).