unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20887@debbugs.gnu.org
Subject: bug#20887: 'make bootstrap' now verrrry slow due to recent isearch changes
Date: Fri, 26 Jun 2015 12:41:52 +0100	[thread overview]
Message-ID: <CAAdUY-KNnv1XDBYMbaxzDJ1kuNbSnJ-ECM4bC6YHfh1_9Ji6Ow@mail.gmail.com> (raw)
In-Reply-To: <83y4j6dhyz.fsf@gnu.org>

> It's not faster, but it's not slower, either.  Looping is not what
> takes time here, and if you think map-char-table can somehow magically
> avoid any looping, you should look at its implementation.

Not magic, witchcraft of course. Completely different things!

But seriously. My logic was just: there are 7k entries with a nil
value, `map-char-table' does the "funcall func + check for nil" stuff
in c code, whereas the loop does it in lisp code; so *if there's a
difference*, it's probably in favor of map-char-table.
But your test has shown that there's probably no significant difference.

That said, I was merely speculating. If you have any reason whatsoever
to prefer the loop (maybe it's even more robust if the table ever
changes) feel free to push, I'm not particular. :-)





  reply	other threads:[~2015-06-26 11:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24  1:35 bug#20887: 'make bootstrap' now verrrry slow due to recent isearch changes Paul Eggert
2015-06-24  7:06 ` Glenn Morris
2015-06-24  7:52   ` Artur Malabarba
2015-06-24 13:36     ` Paul Eggert
2015-06-24 14:28       ` Artur Malabarba
2015-06-24 15:05         ` Eli Zaretskii
2015-06-24 15:19           ` Eli Zaretskii
2015-06-24 17:18             ` Artur Malabarba
2015-06-24 19:14               ` Eli Zaretskii
2015-06-24 20:05                 ` Artur Malabarba
2015-06-24 23:17                   ` Artur Malabarba
2015-06-24 23:37                     ` Artur Malabarba
2015-06-25 15:03                       ` Eli Zaretskii
2015-06-25 17:32                         ` Artur Malabarba
2015-06-26  7:52                           ` Eli Zaretskii
2015-06-26 11:41                             ` Artur Malabarba [this message]
2015-06-26 13:32                               ` Eli Zaretskii
2015-06-24 17:15           ` Glenn Morris
2015-06-24 17:38             ` Artur Malabarba
2015-06-24 15:55     ` Glenn Morris
2015-06-24 13:31   ` Paul Eggert
2015-06-24 15:58     ` Glenn Morris
2015-06-25  2:48       ` Paul Eggert
2015-06-25 23:21         ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAdUY-KNnv1XDBYMbaxzDJ1kuNbSnJ-ECM4bC6YHfh1_9Ji6Ow@mail.gmail.com \
    --to=bruce.connor.am@gmail.com \
    --cc=20887@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).