From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.bugs Subject: bug#20887: 'make bootstrap' now verrrry slow due to recent isearch changes Date: Fri, 26 Jun 2015 12:41:52 +0100 Message-ID: References: <558A0950.2000501@cs.ucla.edu> <2nbng5pou7.fsf@fencepost.gnu.org> <558AB250.5040908@cs.ucla.edu> <83vbeddu4d.fsf@gnu.org> <83si9hdthc.fsf@gnu.org> <83mvzoex5g.fsf@gnu.org> <838ub7eso2.fsf@gnu.org> <83y4j6dhyz.fsf@gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1435318939 19612 80.91.229.3 (26 Jun 2015 11:42:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 26 Jun 2015 11:42:19 +0000 (UTC) Cc: 20887@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 26 13:42:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z8S1L-00036F-Ox for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jun 2015 13:42:12 +0200 Original-Received: from localhost ([::1]:59526 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8S1K-000887-RJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jun 2015 07:42:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8S1H-000882-5G for bug-gnu-emacs@gnu.org; Fri, 26 Jun 2015 07:42:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8S1D-0007xI-3l for bug-gnu-emacs@gnu.org; Fri, 26 Jun 2015 07:42:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8S1D-0007xA-0E for bug-gnu-emacs@gnu.org; Fri, 26 Jun 2015 07:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z8S1C-0006Ti-LA for bug-gnu-emacs@gnu.org; Fri, 26 Jun 2015 07:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jun 2015 11:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20887 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20887-submit@debbugs.gnu.org id=B20887.143531892124896 (code B ref 20887); Fri, 26 Jun 2015 11:42:02 +0000 Original-Received: (at 20887) by debbugs.gnu.org; 26 Jun 2015 11:42:01 +0000 Original-Received: from localhost ([127.0.0.1]:57780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z8S1B-0006TS-9l for submit@debbugs.gnu.org; Fri, 26 Jun 2015 07:42:01 -0400 Original-Received: from mail-la0-f41.google.com ([209.85.215.41]:35622) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z8S18-0006TC-Tn for 20887@debbugs.gnu.org; Fri, 26 Jun 2015 07:41:59 -0400 Original-Received: by lagi2 with SMTP id i2so62075084lag.2 for <20887@debbugs.gnu.org>; Fri, 26 Jun 2015 04:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=nEGD9XSFvU0OJUdcG/rodUVht2InAv/N263loyj4oSI=; b=SA7N9ORBI671+ei5M7lGwhc1HfhvbNBa8h7VdKpv+g/46387Nc4fb0O9mTWsaDDhJj 2h/qnC9u/wK3832VYMOOVG1zPUIo0K829uxOCMkmjHmto0uMxscLDgL4CXJyHq4qZtZR SVtjlj5dmBWRfC2YlgpifP5jc6skOcvUNb7lHs3RIHLtwFlr+6uQIhJnLIF+IL9QFedJ t9U9hj1+Mmfju/yCC43MuqM/3DsRSDkyk9W0aS2DAYvD1ZuZcP/ARs5J2hmgJ9TC7gl5 YeQLG4IQQuVvRHaB/DHOEYWCD7SQ/J6e15e8nviJvECSRW9htt92j5zzph6/OccfCb8D a3dw== X-Received: by 10.112.210.137 with SMTP id mu9mr1139751lbc.95.1435318912910; Fri, 26 Jun 2015 04:41:52 -0700 (PDT) Original-Received: by 10.25.214.133 with HTTP; Fri, 26 Jun 2015 04:41:52 -0700 (PDT) In-Reply-To: <83y4j6dhyz.fsf@gnu.org> X-Google-Sender-Auth: 6NQubfwiPHUyCC9Wa8ud0_aEZXQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104366 Archived-At: > It's not faster, but it's not slower, either. Looping is not what > takes time here, and if you think map-char-table can somehow magically > avoid any looping, you should look at its implementation. Not magic, witchcraft of course. Completely different things! But seriously. My logic was just: there are 7k entries with a nil value, `map-char-table' does the "funcall func + check for nil" stuff in c code, whereas the loop does it in lisp code; so *if there's a difference*, it's probably in favor of map-char-table. But your test has shown that there's probably no significant difference. That said, I was merely speculating. If you have any reason whatsoever to prefer the loop (maybe it's even more robust if the table ever changes) feel free to push, I'm not particular. :-)