bug#25424: 25.1; sql-mode, product mysql: sql-end-of-statement: Wrong type argument: stringp, nil

bug#25424: 25.1; sql-mode, product mysql: sql-end-of-statement: Wrong type argument: stringp, nil

[Tijs Mallaerts]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

To reproduce:
- activate sql-mode
- call M-x sql-set-product
- select mysql
- write a part of a query, f.ex. select * from
- call M-x sql-end-of-statement

Error: sql-end-of-statement: Wrong type argument: stringp, nil

A missing :terminator sql-product-feature of mysql seems to be causing this
issue.

In GNU Emacs 25.1.4 (x86_64-unknown-linux-gnu)
 of 2016-09-24 built on kubuntu
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description:    Ubuntu 16.04.1 LTS

Configured using:
 'configure --with-x-toolkit=no'

Configured features:
XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY LIBXML2 FREETYPE XFT
ZLIB X11

Important settings:
  value of $LC_MONETARY: nl_BE.UTF-8
  value of $LC_NUMERIC: nl_BE.UTF-8
  value of $LC_TIME: nl_BE.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: SQL[MySQL]

[-- Attachment #2: Type: text/html, Size: 1048 bytes --]

bug#25424: [PATCH] Add mysql terminator to sql-product-alist

[Tijs Mallaerts]

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

From b97f29e248a57aea4fe92a606bdd67d2ab274c91 Mon Sep 17 00:00:00 2001
From: tijsmallaerts <tijs.mallaerts@gmail.com>
Date: Fri, 11 Jan 2019 23:05:36 +0100
Subject: [PATCH] Add mysql terminator to sql-product-alist

---
 lisp/progmodes/sql.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el
index ebde684109..42c4ab4e9f 100644
--- a/lisp/progmodes/sql.el
+++ b/lisp/progmodes/sql.el
@@ -459,7 +459,8 @@ file.  Since that is a plaintext file, this could be
dangerous."
      :prompt-length 6
      :prompt-cont-regexp "^    -> "
      :syntax-alist ((?# . "< b"))
-     :input-filter sql-remove-tabs-filter)
+     :input-filter sql-remove-tabs-filter
+     :terminator ";")

     (oracle
      :name "Oracle"
-- 
2.17.1

[-- Attachment #2: Type: text/html, Size: 1053 bytes --]

bug#25424: Add mysql terminator to sql-product-alist

[Tijs Mallaerts]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

I've sent a patch to fix bug 25424 directly to the bug entry of the bug
tracker. Is that the correct place to send the patch to, or is it
recommended to email patches to this mailing list?

Thank you!
Tijs

[-- Attachment #2: Type: text/html, Size: 320 bytes --]

bug#25424:

[Tijs Mallaerts]

[-- Attachment #1: Type: text/plain, Size: 66 bytes --]

Could someone please verify if this patch is ok?

Thank you!
Tijs

[-- Attachment #2: Type: text/html, Size: 136 bytes --]

bug#25424:

[Eli Zaretskii]

> From: Tijs Mallaerts <tijs.mallaerts@gmail.com>
> Date: Fri, 22 Mar 2019 11:33:08 +0100
> 
> Could someone please verify if this patch is ok?

Sorry for the delay, CC'ing the relevant maintainer.

Michael, could you please look at the patch proposed in
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25424#10?

Thanks.

bug#25424:

[Michael Mauger]

I've reviewed the issue. The fix is more appropriate in `sql-end-of-statement'. I'll commit a change to implement this.

Thanks
--
MICHAEL@MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, March 22, 2019 9:15 AM, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Tijs Mallaerts tijs.mallaerts@gmail.com
>
> > Date: Fri, 22 Mar 2019 11:33:08 +0100
> > Could someone please verify if this patch is ok?
>
> Sorry for the delay, CC'ing the relevant maintainer.
>
> Michael, could you please look at the patch proposed in
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25424#10?
>
> Thanks.

bug#25424:

[Eli Zaretskii]

> Date: Sat, 23 Mar 2019 01:43:49 +0000
> From: Michael Mauger <mmauger@protonmail.com>
> Cc: Tijs Mallaerts <tijs.mallaerts@gmail.com>, "Michael R. Mauger" <michael@mauger.com>, "25424@debbugs.gnu.org" <25424@debbugs.gnu.org>
> 
> I've reviewed the issue. The fix is more appropriate in `sql-end-of-statement'. I'll commit a change to implement this.

Thanks.  I see you already made a change; should we now close this bug
report?

bug#25424:

[Michael Mauger]

On Saturday, March 23, 2019 2:56 AM, Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Sat, 23 Mar 2019 01:43:49 +0000
>
> > I've reviewed the issue. The fix is more appropriate in `sql-end-of-statement'. I'll commit a change to implement this.
>
> Thanks. I see you already made a change; should we now close this bug
> report?

Yes, it should now be all set. The bug can be closed.

bug#25424:

[Eli Zaretskii]

> Date: Sun, 24 Mar 2019 19:31:11 +0000
> From: Michael Mauger <mmauger@protonmail.com>
> Cc: "tijs.mallaerts@gmail.com" <tijs.mallaerts@gmail.com>, "michael@mauger.com" <michael@mauger.com>, "25424@debbugs.gnu.org" <25424@debbugs.gnu.org>
> 
> > Thanks. I see you already made a change; should we now close this bug
> > report?
> 
> Yes, it should now be all set. The bug can be closed.

Done, thanks.

bug#25424:

[Tijs Mallaerts]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Thanks a lot!

Op zo 24 mrt. 2019 om 20:52 schreef Eli Zaretskii <eliz@gnu.org>:

> > Date: Sun, 24 Mar 2019 19:31:11 +0000
> > From: Michael Mauger <mmauger@protonmail.com>
> > Cc: "tijs.mallaerts@gmail.com" <tijs.mallaerts@gmail.com>, "
> michael@mauger.com" <michael@mauger.com>, "25424@debbugs.gnu.org" <
> 25424@debbugs.gnu.org>
> >
> > > Thanks. I see you already made a change; should we now close this bug
> > > report?
> >
> > Yes, it should now be all set. The bug can be closed.
>
> Done, thanks.
>

[-- Attachment #2: Type: text/html, Size: 1309 bytes --]