From: Constantine Vetoshev <vetoshev@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 32338@debbugs.gnu.org, Noam Postavsky <npostavs@gmail.com>
Subject: bug#32338: 26.1; term.el broken on macOS
Date: Sat, 29 Sep 2018 16:52:40 -0700 [thread overview]
Message-ID: <CA+CaSqp-wYNKGBxVPAL2gVyafJK=C_eMt-_+XgYrvjfncjT+xw@mail.gmail.com> (raw)
In-Reply-To: <838t3sdb29.fsf@gnu.org>
On Sat, Sep 22, 2018 at 10:42 PM Eli Zaretskii <eliz@gnu.org> wrote:
> Thanks for your efforts. I hope one of the NS experts will chime in
> soon.
After bisecting between 25.3 and 26.1, I tracked down the breaking
commit, 4cdd14eabe5a6121691daa2d9c5e814c5f53f3e5.
It seems like it was supposed to only impact Windows. I was so
surprised that I checked twice to confirm. The breaking change was to
src/emacs.c, in the type change from long to rlim_t (two places).
Reverting just that one file's change fixes the crash. I
double-checked by applying the relevant patch to the 26.1 release
source tree, and that fixed it.
Checking my (macOS) system, rlim_t seems to be typedefed to
__uint64_t, which definitely makes a difference, though I admit the
nature of the crash is rather mystifying compared to what has actually
changed. Eli, since you were working on this, any ideas about the
right approach to fixing the problem other than blindly reverting the
change?
next prev parent reply other threads:[~2018-09-29 23:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 19:29 bug#32338: 26.1; term.el broken on macOS Constantine Vetoshev
2018-09-19 23:30 ` Noam Postavsky
2018-09-20 14:15 ` Constantine Vetoshev
2018-09-21 0:35 ` Noam Postavsky
2018-09-22 18:12 ` Constantine Vetoshev
2018-09-22 22:14 ` Noam Postavsky
2018-09-23 5:42 ` Eli Zaretskii
2018-09-29 23:52 ` Constantine Vetoshev [this message]
2018-09-30 5:59 ` Eli Zaretskii
2018-09-30 15:25 ` Constantine Vetoshev
2018-09-30 17:13 ` Eli Zaretskii
2018-10-02 22:51 ` Constantine Vetoshev
2018-10-03 14:59 ` Eli Zaretskii
2018-10-03 19:21 ` Constantine Vetoshev
2018-10-04 16:15 ` Eli Zaretskii
2018-09-30 9:16 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+CaSqp-wYNKGBxVPAL2gVyafJK=C_eMt-_+XgYrvjfncjT+xw@mail.gmail.com' \
--to=vetoshev@gmail.com \
--cc=32338@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).