From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Constantine Vetoshev Newsgroups: gmane.emacs.bugs Subject: bug#32338: 26.1; term.el broken on macOS Date: Sat, 29 Sep 2018 16:52:40 -0700 Message-ID: References: <87k1nhoyji.fsf@gmail.com> <87bm8rpu0x.fsf@gmail.com> <87o9cpnpry.fsf@gmail.com> <838t3sdb29.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1538265074 15224 195.159.176.226 (29 Sep 2018 23:51:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 29 Sep 2018 23:51:14 +0000 (UTC) Cc: 32338@debbugs.gnu.org, Noam Postavsky To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 30 01:51:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6P0v-0003nE-9i for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Sep 2018 01:51:09 +0200 Original-Received: from localhost ([::1]:53040 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6P2w-0002cH-TX for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Sep 2018 19:53:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6P2n-0002c0-O4 for bug-gnu-emacs@gnu.org; Sat, 29 Sep 2018 19:53:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6P2k-0004rX-Fw for bug-gnu-emacs@gnu.org; Sat, 29 Sep 2018 19:53:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55027) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6P2k-0004rP-BO for bug-gnu-emacs@gnu.org; Sat, 29 Sep 2018 19:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g6P2k-0005Wd-8J for bug-gnu-emacs@gnu.org; Sat, 29 Sep 2018 19:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Constantine Vetoshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Sep 2018 23:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32338-submit@debbugs.gnu.org id=B32338.153826517821229 (code B ref 32338); Sat, 29 Sep 2018 23:53:02 +0000 Original-Received: (at 32338) by debbugs.gnu.org; 29 Sep 2018 23:52:58 +0000 Original-Received: from localhost ([127.0.0.1]:59285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6P2g-0005WL-9o for submit@debbugs.gnu.org; Sat, 29 Sep 2018 19:52:58 -0400 Original-Received: from mail-vs1-f47.google.com ([209.85.217.47]:37715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6P2f-0005W7-0d for 32338@debbugs.gnu.org; Sat, 29 Sep 2018 19:52:57 -0400 Original-Received: by mail-vs1-f47.google.com with SMTP id w8-v6so5599617vsl.4 for <32338@debbugs.gnu.org>; Sat, 29 Sep 2018 16:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+JuwfNmR42HJhwBc5WcXTJaCbCQDYCCc/FfGJmf4x+4=; b=usuIJzVme/3vlJcGhQuji94pwKPWP0GH+2wNQoL3uvf+ZEHEhWkK6JDquHB4uhIA0l QhuEskPkSdX2bbrD9Uy2OOSZ3T3Z8+p7LVWcxTGLVV60Rr67wYBA8JEga371gDeLd88b ap0GbsgE32VTb4a2V2iMir2jAwjSB9O/07dhTGPkZQiZu9/Gr630svSvXUHCIAWplM2N 1tM5phDAXiXjF5Cj9dlIPT346BZeTxpmaFTsGw8AwUEWLFYJQXtbVEedCpwBd+3VYX66 GiVrH4sbK4KdvEzBoSccCbQxLdCl3puWzHTuZz+KCqX2+iBF+GoZYYKfGoN24HiYVVoZ PD7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+JuwfNmR42HJhwBc5WcXTJaCbCQDYCCc/FfGJmf4x+4=; b=s2i1mhgIG6jLlD+/qAAhvGTmnAFBFxY41pqqq6UC5/DehfZK065xFqn15P3c4OyuxJ f982u3vfxMQVgmU9w7A8PWWM15dzDOoH7bpj6UOWAXxxQEE9N26mFJ7/1TftnFpoUZ3S hdzOFiVv35u/+1u+8sMyxS3TMocXsOkiAHmDdCX+kCchfeBcNfzJ8hrwJ5ANITMkFFB6 mfNPZ2mIiduD2i3huJgfhnimhZgZIy8R05kgkgjN1MBNZ8x3a7iBMK9TQWeg7mxcJt5S uPrxL7OqRtWFoYw1P/xKKPOJIGD5Z7o3sR9yrzWwvtNeFltoEMdH4Unv0jfDSpGto715 FSPw== X-Gm-Message-State: ABuFfohEx1KgAq+46QU5E0dEVWqsqmi9rL29pj9gkJA0CZEkSTpq1jUg WteV26ncQtXYm+RXpkj9I5ERDE0IBw0rNC+6WH8= X-Google-Smtp-Source: ACcGV60WwCF/G6HEspERElCoSoVQpbnQ/8ixY6OKWJZ1fKrRF8wTpiYcT/GhpUPO9J5FBXtwN9jRQkTUCVXlwUjdqnA= X-Received: by 2002:a67:8c83:: with SMTP id o125-v6mr1818100vsd.3.1538265171348; Sat, 29 Sep 2018 16:52:51 -0700 (PDT) In-Reply-To: <838t3sdb29.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150777 Archived-At: On Sat, Sep 22, 2018 at 10:42 PM Eli Zaretskii wrote: > Thanks for your efforts. I hope one of the NS experts will chime in > soon. After bisecting between 25.3 and 26.1, I tracked down the breaking commit, 4cdd14eabe5a6121691daa2d9c5e814c5f53f3e5. It seems like it was supposed to only impact Windows. I was so surprised that I checked twice to confirm. The breaking change was to src/emacs.c, in the type change from long to rlim_t (two places). Reverting just that one file's change fixes the crash. I double-checked by applying the relevant patch to the 26.1 release source tree, and that fixed it. Checking my (macOS) system, rlim_t seems to be typedefed to __uint64_t, which definitely makes a difference, though I admit the nature of the crash is rather mystifying compared to what has actually changed. Eli, since you were working on this, any ideas about the right approach to fixing the problem other than blindly reverting the change?