From: Jaft <jaft.r@outlook.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "55900@debbugs.gnu.org" <55900@debbugs.gnu.org>
Subject: bug#55900: [PATCH] Hierarchy – Defer the Computation of Children
Date: Thu, 27 Oct 2022 19:14:15 +0000 (UTC) [thread overview]
Message-ID: <BY5PR07MB7029DD84E2ED82E78E166DE699339@BY5PR07MB7029.namprd07.prod.outlook.com> (raw)
In-Reply-To: <83edutkwyh.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 2707 bytes --]
Sorry about that, Eli. Looks like it was a typo, on my part; I could've sworn I'd went through and, you know, run each of these tests when I'd first made them so I'm sorry this one seemed to've slipped through. It looks to be passing, now, with the proper values in place.
On Thursday, October 27, 2022 at 12:17:37 PM CDT, Eli Zaretskii <eliz@gnu.org> wrote:
> Date: Thu, 27 Oct 2022 16:13:05 +0000 (UTC)
> From: Jaft <jaft.r@outlook.com>
> Cc: "55900@debbugs.gnu.org" <55900@debbugs.gnu.org>
>
> I've submitted my copyright assignment and've been informed it's been completed.
>
> We should be ready to proceed, as far as I understand.
Thanks. I installed the changeset, but one of the tests you added
fails here:
Test hierarchy-delayed-add-trees backtrace:
signal(ert-test-failed (((should (equal (hierarchy-children hierarch
ert-fail(((should (equal (hierarchy-children hierarchy '191) '(190 1
(if (unwind-protect (setq value-714 (apply fn-712 args-713)) (setq f
(let (form-description-716) (if (unwind-protect (setq value-714 (app
(let ((value-714 'ert-form-evaluation-aborted-715)) (let (form-descr
(let* ((fn-712 #'equal) (args-713 (condition-case err (let ((signal-
(let ((parentfn #'(lambda (item) (cond ((eql item ...) '191) ((eql i
(closure (t) nil (let ((parentfn #'(lambda (item) (cond (... ...) (.
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name hierarchy-delayed-add-trees :document
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/emacs-lisp/hierarchy
command-line()
normal-top-level()
Test hierarchy-delayed-add-trees condition:
(ert-test-failed
((should
(equal
(hierarchy-children hierarchy ...)
'(190 190.5)))
:form
(equal
(190.5)
(190 190.5))
:value nil :explanation
(proper-lists-of-different-length 1 2
(190.5)
(190 190.5)
first-mismatch-at 0)))
FAILED 24/68 hierarchy-delayed-add-trees (0.000000 sec) at lisp/emacs-lisp/hierarchy-tests.el:685
Could you please work on fixing this test?
Thanks.
[-- Attachment #1.2: Type: text/html, Size: 5415 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-failing-test-for-package-Hierarchy.patch --]
[-- Type: text/x-patch, Size: 1208 bytes --]
From d1f00a672953cfb1a58959cd32f09ae63a4172ee Mon Sep 17 00:00:00 2001
From: "Wamm K. D" <jaft.r@outlook.com>
Date: Thu, 27 Oct 2022 14:07:03 -0500
Subject: [PATCH] Fix failing test for package Hierarchy
This fixes a typo in one of the tests of Hierarchy which was causing
the test to fail.
* test/lisp/emacs-lisp/hierarchy-tests.el: Fix typo in hierarchy-delayed-add-trees
---
test/lisp/emacs-lisp/hierarchy-tests.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/lisp/emacs-lisp/hierarchy-tests.el b/test/lisp/emacs-lisp/hierarchy-tests.el
index d83460a2ba..97a0f7ba52 100644
--- a/test/lisp/emacs-lisp/hierarchy-tests.el
+++ b/test/lisp/emacs-lisp/hierarchy-tests.el
@@ -689,7 +689,7 @@ and then create a list of the number plus 0.0–0.9."
(190.5 '191)
(191 '192))))
(hierarchy (hierarchy-new)))
- (hierarchy-add-trees hierarchy '(191 190.5) parentfn
+ (hierarchy-add-trees hierarchy '(190 190.5) parentfn
#'hierarchy-examples-delayed--childrenfn nil t)
(should (equal (hierarchy-roots hierarchy) '(192)))
(should (equal (hierarchy-children hierarchy '192) '(191)))
--
2.38.0
next prev parent reply other threads:[~2022-10-27 19:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 6:52 bug#55900: [PATCH] Hierarchy – Defer the Computation of Children Wamm K. D.
2022-06-11 8:21 ` Eli Zaretskii
2022-06-12 9:01 ` Wamm K. D.
[not found] ` <87mtei1cii.fsf@outlook.com>
2022-06-12 9:07 ` Jaft
2022-07-28 8:48 ` Eli Zaretskii
[not found] ` <1383718586.2581914.1655024858024@mail.yahoo.com>
2022-07-27 12:36 ` Jaft
2022-07-28 8:52 ` Eli Zaretskii
2022-08-04 0:20 ` Jaft
2022-08-04 6:12 ` Eli Zaretskii
2022-10-27 16:13 ` Jaft
2022-10-27 17:17 ` Eli Zaretskii
2022-10-27 19:14 ` Jaft [this message]
2022-10-28 7:36 ` Eli Zaretskii
2022-10-28 7:52 ` Jaft
2022-10-28 7:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR07MB7029DD84E2ED82E78E166DE699339@BY5PR07MB7029.namprd07.prod.outlook.com \
--to=jaft.r@outlook.com \
--cc=55900@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).