unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jaft <jaft.r@outlook.com>
Cc: 55900@debbugs.gnu.org
Subject: bug#55900: [PATCH] Hierarchy – Defer the Computation of Children
Date: Thu, 27 Oct 2022 20:17:26 +0300	[thread overview]
Message-ID: <83edutkwyh.fsf@gnu.org> (raw)
In-Reply-To: <BY5PR07MB7029F0F2C571469498808CFF99339@BY5PR07MB7029.namprd07.prod.outlook.com> (message from Jaft on Thu, 27 Oct 2022 16:13:05 +0000 (UTC))

> Date: Thu, 27 Oct 2022 16:13:05 +0000 (UTC)
> From: Jaft <jaft.r@outlook.com>
> Cc: "55900@debbugs.gnu.org" <55900@debbugs.gnu.org>
> 
> I've submitted my copyright assignment and've been informed it's been completed.
> 
> We should be ready to proceed, as far as I understand.

Thanks.  I installed the changeset, but one of the tests you added
fails here:

  Test hierarchy-delayed-add-trees backtrace:
    signal(ert-test-failed (((should (equal (hierarchy-children hierarch
    ert-fail(((should (equal (hierarchy-children hierarchy '191) '(190 1
    (if (unwind-protect (setq value-714 (apply fn-712 args-713)) (setq f
    (let (form-description-716) (if (unwind-protect (setq value-714 (app
    (let ((value-714 'ert-form-evaluation-aborted-715)) (let (form-descr
    (let* ((fn-712 #'equal) (args-713 (condition-case err (let ((signal-
    (let ((parentfn #'(lambda (item) (cond ((eql item ...) '191) ((eql i
    (closure (t) nil (let ((parentfn #'(lambda (item) (cond (... ...) (.
    ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
    ert-run-test(#s(ert-test :name hierarchy-delayed-add-trees :document
    ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
    ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
    ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
    ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
    eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
    command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/emacs-lisp/hierarchy
    command-line()
    normal-top-level()
  Test hierarchy-delayed-add-trees condition:
      (ert-test-failed
       ((should
	 (equal
	  (hierarchy-children hierarchy ...)
	  '(190 190.5)))
	:form
	(equal
	 (190.5)
	 (190 190.5))
	:value nil :explanation
	(proper-lists-of-different-length 1 2
					  (190.5)
					  (190 190.5)
					  first-mismatch-at 0)))
     FAILED  24/68  hierarchy-delayed-add-trees (0.000000 sec) at lisp/emacs-lisp/hierarchy-tests.el:685

Could you please work on fixing this test?

Thanks.





  reply	other threads:[~2022-10-27 17:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-11  6:52 bug#55900: [PATCH] Hierarchy – Defer the Computation of Children Wamm K. D.
2022-06-11  8:21 ` Eli Zaretskii
2022-06-12  9:01   ` Wamm K. D.
     [not found]   ` <87mtei1cii.fsf@outlook.com>
2022-06-12  9:07     ` Jaft
2022-07-28  8:48       ` Eli Zaretskii
     [not found]     ` <1383718586.2581914.1655024858024@mail.yahoo.com>
2022-07-27 12:36       ` Jaft
2022-07-28  8:52         ` Eli Zaretskii
2022-08-04  0:20           ` Jaft
2022-08-04  6:12             ` Eli Zaretskii
2022-10-27 16:13               ` Jaft
2022-10-27 17:17                 ` Eli Zaretskii [this message]
2022-10-27 19:14                   ` Jaft
2022-10-28  7:36                     ` Eli Zaretskii
2022-10-28  7:52                       ` Jaft
2022-10-28  7:56                         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83edutkwyh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=55900@debbugs.gnu.org \
    --cc=jaft.r@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).