unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#5543: 23.1; mistake of file name extension in nnrss-check-group of gnus
@ 2010-02-08  9:02 Toru TSUNEYOSHI
  2010-09-30 21:09 ` Lars Magne Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Toru TSUNEYOSHI @ 2010-02-08  9:02 UTC (permalink / raw)
  To: 5543

Hello.

In function `nnrss-check-group' of lisp/gnus/nnrss.el (of GNU Emacs
23.1), there is a mistake of file name extension.
Please fix it.

(file-exists-p (setq file (expand-file-name
			   (nnrss-translate-file-chars
			    (concat group ".xml")) ; => should be ".el"
			   nnrss-directory))))

Or shoud replace with `nnrss-make-filename', I think.

(file-exists-p (setq file (nnrss-make-filename group server))))







^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#5543: 23.1; mistake of file name extension in nnrss-check-group of gnus
  2010-02-08  9:02 bug#5543: 23.1; mistake of file name extension in nnrss-check-group of gnus Toru TSUNEYOSHI
@ 2010-09-30 21:09 ` Lars Magne Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-30 21:09 UTC (permalink / raw)
  To: Toru TSUNEYOSHI; +Cc: bug-gnu-emacs, 5543-close

Toru TSUNEYOSHI <t_tuneyosi@hotmail.com> writes:

> In function `nnrss-check-group' of lisp/gnus/nnrss.el (of GNU Emacs
> 23.1), there is a mistake of file name extension.
> Please fix it.
>
> (file-exists-p (setq file (expand-file-name
> 			   (nnrss-translate-file-chars
> 			    (concat group ".xml")) ; => should be ".el"
> 			   nnrss-directory))))

No, that code is from the path taken when `nnrss-use-local' is used, and
it then reads local xml files, so I think it's correct.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-30 21:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-08  9:02 bug#5543: 23.1; mistake of file name extension in nnrss-check-group of gnus Toru TSUNEYOSHI
2010-09-30 21:09 ` Lars Magne Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).