unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 55628@debbugs.gnu.org, larsi@gnus.org
Subject: bug#55628: debug-timer-check fails on macOS 11.6.6
Date: Thu, 26 May 2022 11:57:58 +0200	[thread overview]
Message-ID: <BF8CC901-ECDD-4E96-9636-C255144569AE@acm.org> (raw)
In-Reply-To: <83sfoxpmff.fsf@gnu.org>

25 maj 2022 kl. 19.11 skrev Eli Zaretskii <eliz@gnu.org>:

> Btw, this test will never work on a platform that only has setitimer,
> because only one ITIMER_REAL timer is guaranteed to exist, and the
> function attempts to arm 10 timers at the same time.

That's not how the code works. `setitimer` will only be called for the first timer to expire.
(The test works correctly on this computer, that only has setitimer, after applying the patch.)

Another demonstration of this bug:

(funcall-with-delayed-message
 0.1 "haha" (lambda () (sit-for 3)))

will, on this machine, display "haha" after 1 s if unpatched, but after 0.1 s if patched.

(This is with -nw because the NS backend seems to be slow handling async events on its own, but that's a different bug.)

> We don't usually have testing code in a production build, so why make
> an exception here?  Especially since atimers are an obscure feature
> used internally by Emacs.

There's nothing bad or even unusual about including interfaces for internal testing in production builds, as long as it doesn't unduly reduce performance or cause significant bloat. It's always a trade-off, of course.






  reply	other threads:[~2022-05-26  9:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 10:46 bug#55628: debug-timer-check fails on macOS 11.6.6 Mattias Engdegård
2022-05-25 12:20 ` Lars Ingebrigtsen
2022-05-25 13:05   ` Mattias Engdegård
2022-05-25 14:02     ` Eli Zaretskii
2022-05-25 15:34     ` Mattias Engdegård
2022-05-25 17:11       ` Eli Zaretskii
2022-05-26  9:57         ` Mattias Engdegård [this message]
2022-05-26 11:37           ` Eli Zaretskii
2022-05-26 13:15             ` Mattias Engdegård
2022-05-30 10:43               ` Mattias Engdegård
2022-05-30 13:42                 ` Lars Ingebrigtsen
2022-05-30 13:55                   ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BF8CC901-ECDD-4E96-9636-C255144569AE@acm.org \
    --to=mattiase@acm.org \
    --cc=55628@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).