From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 55628@debbugs.gnu.org, larsi@gnus.org
Subject: bug#55628: debug-timer-check fails on macOS 11.6.6
Date: Thu, 26 May 2022 14:37:15 +0300 [thread overview]
Message-ID: <837d68plsk.fsf@gnu.org> (raw)
In-Reply-To: <BF8CC901-ECDD-4E96-9636-C255144569AE@acm.org> (message from Mattias Engdegård on Thu, 26 May 2022 11:57:58 +0200)
> From: Mattias Engdegård <mattiase@acm.org>
> Date: Thu, 26 May 2022 11:57:58 +0200
> Cc: larsi@gnus.org, 55628@debbugs.gnu.org
>
> 25 maj 2022 kl. 19.11 skrev Eli Zaretskii <eliz@gnu.org>:
>
> > Btw, this test will never work on a platform that only has setitimer,
> > because only one ITIMER_REAL timer is guaranteed to exist, and the
> > function attempts to arm 10 timers at the same time.
>
> That's not how the code works. `setitimer` will only be called for the first timer to expire.
Maybe I've misread the code, then. Apologies.
> > We don't usually have testing code in a production build, so why make
> > an exception here? Especially since atimers are an obscure feature
> > used internally by Emacs.
>
> There's nothing bad or even unusual about including interfaces for internal testing in production builds, as long as it doesn't unduly reduce performance or cause significant bloat. It's always a trade-off, of course.
Not in principle, but we in this project don't do that. E.g., there
are several debug-related functions and commands in xdisp.c that are
only compiled in under ENABLE_CHECKING.
So if we are going to make an exception for this case, we should have
some good reason.
next prev parent reply other threads:[~2022-05-26 11:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 10:46 bug#55628: debug-timer-check fails on macOS 11.6.6 Mattias Engdegård
2022-05-25 12:20 ` Lars Ingebrigtsen
2022-05-25 13:05 ` Mattias Engdegård
2022-05-25 14:02 ` Eli Zaretskii
2022-05-25 15:34 ` Mattias Engdegård
2022-05-25 17:11 ` Eli Zaretskii
2022-05-26 9:57 ` Mattias Engdegård
2022-05-26 11:37 ` Eli Zaretskii [this message]
2022-05-26 13:15 ` Mattias Engdegård
2022-05-30 10:43 ` Mattias Engdegård
2022-05-30 13:42 ` Lars Ingebrigtsen
2022-05-30 13:55 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837d68plsk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55628@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).