* bug#58604: [PATCH] Fix x11 with i18n build
@ 2022-10-18 1:46 Randy Taylor
2022-10-18 11:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Randy Taylor @ 2022-10-18 1:46 UTC (permalink / raw)
To: 58604
[-- Attachment #1.1: Type: text/plain, Size: 228 bytes --]
With no toolkit, no xrandr, no xinput2 and having i18n, the dpyinfo variable is not created but is used later on, causing the build to fail.
The attached patch fixes the problem.
FYI I should have copyright assignment on file.
[-- Attachment #1.2: Type: text/html, Size: 690 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-src-xterm.c-mark_xterm-Fix-x11-with-i18n-build.patch --]
[-- Type: text/x-patch; name=0001-src-xterm.c-mark_xterm-Fix-x11-with-i18n-build.patch, Size: 756 bytes --]
From e07823232716f5159239f9215ca3cbadbfa14f9e Mon Sep 17 00:00:00 2001
From: Randy Taylor <dev@rjt.dev>
Date: Mon, 17 Oct 2022 21:29:30 -0400
Subject: [PATCH] ; * src/xterm.c (mark_xterm): Fix x11 with i18n build
---
src/xterm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/xterm.c b/src/xterm.c
index 7c3ab87e87..3075b5af23 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -30281,7 +30281,7 @@ mark_xterm (void)
{
Lisp_Object val;
#if defined HAVE_XINPUT2 || defined USE_TOOLKIT_SCROLL_BARS \
- || defined HAVE_XRANDR || defined USE_GTK
+ || defined HAVE_XRANDR || defined USE_GTK || defined HAVE_X_I18N
struct x_display_info *dpyinfo;
#if defined HAVE_XINPUT2 || defined USE_TOOLKIT_SCROLL_BARS
int i;
--
2.38.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#58604: [PATCH] Fix x11 with i18n build
2022-10-18 1:46 bug#58604: [PATCH] Fix x11 with i18n build Randy Taylor
@ 2022-10-18 11:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-18 14:55 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-10-18 11:00 UTC (permalink / raw)
To: Randy Taylor; +Cc: 58604
Randy Taylor <dev@rjt.dev> writes:
> With no toolkit, no xrandr, no xinput2 and having i18n, the dpyinfo variable is not created but is used later on, causing the build to fail.
>
> The attached patch fixes the problem.
>
> FYI I should have copyright assignment on file.
Thanks. Would someone please confirm either that, or that you are
currently within the 15-line copyright assignment exemption?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#58604: [PATCH] Fix x11 with i18n build
2022-10-18 11:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2022-10-18 14:55 ` Eli Zaretskii
2022-10-19 0:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2022-10-18 14:55 UTC (permalink / raw)
To: Po Lu; +Cc: 58604, dev
> Cc: 58604@debbugs.gnu.org
> Date: Tue, 18 Oct 2022 19:00:45 +0800
> From: Po Lu via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> Randy Taylor <dev@rjt.dev> writes:
>
> > With no toolkit, no xrandr, no xinput2 and having i18n, the dpyinfo variable is not created but is used later on, causing the build to fail.
> >
> > The attached patch fixes the problem.
> >
> > FYI I should have copyright assignment on file.
>
> Thanks. Would someone please confirm either that, or that you are
> currently within the 15-line copyright assignment exemption?
Assignment is on file; confirmed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#58604: [PATCH] Fix x11 with i18n build
2022-10-18 14:55 ` Eli Zaretskii
@ 2022-10-19 0:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-19 1:08 ` Randy Taylor
2022-11-11 13:28 ` Stefan Kangas
0 siblings, 2 replies; 6+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-10-19 0:54 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 58604, dev
Eli Zaretskii <eliz@gnu.org> writes:
> Assignment is on file; confirmed.
OK, I will install this now.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#58604: [PATCH] Fix x11 with i18n build
2022-10-19 0:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2022-10-19 1:08 ` Randy Taylor
2022-11-11 13:28 ` Stefan Kangas
1 sibling, 0 replies; 6+ messages in thread
From: Randy Taylor @ 2022-10-19 1:08 UTC (permalink / raw)
To: Po Lu; +Cc: 58604, Eli Zaretskii
On Tuesday, October 18th, 2022 at 20:54, Po Lu <luangruo@yahoo.com> wrote:
> OK, I will install this now.
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#58604: [PATCH] Fix x11 with i18n build
2022-10-19 0:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-19 1:08 ` Randy Taylor
@ 2022-11-11 13:28 ` Stefan Kangas
1 sibling, 0 replies; 6+ messages in thread
From: Stefan Kangas @ 2022-11-11 13:28 UTC (permalink / raw)
To: Po Lu; +Cc: 58604-done, dev, Eli Zaretskii
Po Lu <luangruo@yahoo.com> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> Assignment is on file; confirmed.
>
> OK, I will install this now.
This was installed as 620f18c489ff9ce3d0a4afe04d438a1bc0525e73.
It seems the bug was left opened, closing now.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-11 13:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-18 1:46 bug#58604: [PATCH] Fix x11 with i18n build Randy Taylor
2022-10-18 11:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-18 14:55 ` Eli Zaretskii
2022-10-19 0:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-19 1:08 ` Randy Taylor
2022-11-11 13:28 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).