From: Arthur Miller <arthur.miller@live.com>
To: Jean Louis <bugs@gnu.support>
Cc: 47432@debbugs.gnu.org
Subject: bug#47432: 28.0.50; Dired using ! or & on file should fail without command supplied
Date: Sat, 27 Mar 2021 14:59:40 +0100 [thread overview]
Message-ID: <AM9PR09MB4977DF9537A6735DC95D1F1D96609@AM9PR09MB4977.eurprd09.prod.outlook.com> (raw)
In-Reply-To: <YF7v6d5lviYg+Ra9@protected.localdomain> (Jean Louis's message of "Sat, 27 Mar 2021 11:42:17 +0300")
Jean Louis <bugs@gnu.support> writes:
> * Arthur Miller <arthur.miller@live.com> [2021-03-27 10:52]:
>> Jean Louis <bugs@gnu.support> writes:
>>
>> > In Dired, when using ! or & on a file, it should file if there is no
>> > command supplied.
>> >
>> > This is what happens if I use ! on file ~/.asoundrc but without
>> > supplying command, just pressing RET:
>> >
>> > /bin/bash: line 1: .asoundrc: command not found
>> >
>> > But it should not, if command is not supplied in:
>> > (dired-do-shell-command COMMAND &optional ARG FILE-LIST) -- then it
>> > shall rather silently fail or tell "Command not entered" or nothing to
>> > do.
>>
>> Why is "Command not entered" to prefer to "Command not found"?
>
> It is meant as example, I leave those decisions to developers.
>
> Now I can see that ! and & without command are acting on the file as
> the file should be executed.
>
> Let us say I have Screenshot.pl executable file, if I run ! on it, the
> file is executed.
Ja. I guess there is a shebang on it so bash invoked perl interpreter
and executed the file.
> This means there was attempt to execute ~/.asoundrc -- I find that
> insecure and not logical.
Ja. Because you invoked a command that will execute a script on a
file. And since file wasn't executable it failed. So why is it insecured?
> And I do not understand it quite how it works. Was there an attempt to
> execute program with bash?
How you seen the docs? For example C-h k ! RET:
Signature
(dired-do-shell-command COMMAND &optional ARG FILE-LIST)
Documentation
Run a shell command COMMAND on the marked files.
> Why should there be attempt to execute non-executable files?
Because you asked it to by calling ! or & on a file in Dired.
next prev parent reply other threads:[~2021-03-27 13:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 7:09 bug#47432: 28.0.50; Dired using ! or & on file should fail without command supplied Jean Louis
2021-03-27 7:51 ` Arthur Miller
2021-03-27 8:42 ` Jean Louis
2021-03-27 13:59 ` Arthur Miller [this message]
2021-03-27 18:54 ` Jean Louis
2021-03-27 20:28 ` Arthur Miller
2021-03-28 7:50 ` Jean Louis
2021-03-28 8:13 ` Eli Zaretskii
2021-03-29 18:51 ` Jean Louis
2021-03-29 19:23 ` Eli Zaretskii
2021-03-28 14:03 ` Lars Ingebrigtsen
2021-03-28 15:00 ` Andreas Schwab
2021-03-28 15:06 ` Lars Ingebrigtsen
2021-03-29 18:55 ` Jean Louis
2021-03-29 18:34 ` Jean Louis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM9PR09MB4977DF9537A6735DC95D1F1D96609@AM9PR09MB4977.eurprd09.prod.outlook.com \
--to=arthur.miller@live.com \
--cc=47432@debbugs.gnu.org \
--cc=bugs@gnu.support \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).