unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Jean Louis <bugs@gnu.support>
Cc: 47432@debbugs.gnu.org
Subject: bug#47432: 28.0.50; Dired using ! or & on file should fail without command supplied
Date: Sun, 28 Mar 2021 16:03:32 +0200	[thread overview]
Message-ID: <877dlrs7d7.fsf@gnus.org> (raw)
In-Reply-To: <86sg4hnkdo.fsf@protected.rcdrun.com> (Jean Louis's message of "Sat, 27 Mar 2021 10:09:07 +0300")

Jean Louis <bugs@gnu.support> writes:

> In Dired, when using ! or & on a file, it should file if there is no
> command supplied.
>
> This is what happens if I use ! on file ~/.asoundrc but without
> supplying command, just pressing RET:
>
> /bin/bash: line 1: .asoundrc: command not found
>
> But it should not, if command is not supplied in:
> (dired-do-shell-command COMMAND &optional ARG FILE-LIST) -- then it
> shall rather silently fail or tell "Command not entered" or nothing to
> do.

I think that would be a bit odd.  But I see that the doc string doesn't
explicitly say that happens here, so I've added the following sentence
to the doc string in Emacs 28:

----
When executing, FILE-LIST is appended to the COMMAND string.
----

And that's what happening here -- COMMAND is "", and FILE-LIST is
appended to that, and then executed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2021-03-28 14:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27  7:09 bug#47432: 28.0.50; Dired using ! or & on file should fail without command supplied Jean Louis
2021-03-27  7:51 ` Arthur Miller
2021-03-27  8:42   ` Jean Louis
2021-03-27 13:59     ` Arthur Miller
2021-03-27 18:54       ` Jean Louis
2021-03-27 20:28         ` Arthur Miller
2021-03-28  7:50           ` Jean Louis
2021-03-28  8:13             ` Eli Zaretskii
2021-03-29 18:51               ` Jean Louis
2021-03-29 19:23                 ` Eli Zaretskii
2021-03-28 14:03 ` Lars Ingebrigtsen [this message]
2021-03-28 15:00   ` Andreas Schwab
2021-03-28 15:06     ` Lars Ingebrigtsen
2021-03-29 18:55     ` Jean Louis
2021-03-29 18:34   ` Jean Louis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dlrs7d7.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=47432@debbugs.gnu.org \
    --cc=bugs@gnu.support \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).