bug#65190: 30.0.50; Emacs doesn't build with `--with-mailutils` by default when mailutils is installed on macOS

bug#65190: 30.0.50; Emacs doesn't build with `--with-mailutils` by default when mailutils is installed on macOS

[Mou Tong]

After the android branch merged, the file `configure.ac`'s section about
`mailutils` changed.

When I build Emacs on macOS with `./configure`, cli will remind me:

```
configure: WARNING: This configuration installs a 'movemail' program
that does not retrieve POP3 email.  By default, Emacs 25 and earlier
installed a 'movemail' program that retrieved POP3 email via only
insecure channels, a practice that is no longer recommended but that
you can continue to support by using './configure --with-pop'.
configure: You might want to use './configure --with-mailutils'.
```

I have installed mailtuils by homebrew (a package manager on macOS), and
it works fine before the android branch got merged.

I guess the problem occurs in this line

https://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac?id=e1d08e9e11d2bd5e93c8ae4ea4a8e27129b316cb#n349

But I don't know how to fix this :(

bug#65190: 30.0.50; Emacs doesn't build with `--with-mailutils` by default when mailutils is installed on macOS

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Mou Tong <mou.tong@outlook.com> writes:

> After the android branch merged, the file `configure.ac`'s section about
> `mailutils` changed.
>
> When I build Emacs on macOS with `./configure`, cli will remind me:
>
> ```
> configure: WARNING: This configuration installs a 'movemail' program
> that does not retrieve POP3 email.  By default, Emacs 25 and earlier
> installed a 'movemail' program that retrieved POP3 email via only
> insecure channels, a practice that is no longer recommended but that
> you can continue to support by using './configure --with-pop'.
> configure: You might want to use './configure --with-mailutils'.
> ```
>
> I have installed mailtuils by homebrew (a package manager on macOS), and
> it works fine before the android branch got merged.
>
> I guess the problem occurs in this line
>
> https://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac?id=e1d08e9e11d2bd5e93c8ae4ea4a8e27129b316cb#n349
>
> But I don't know how to fix this :(

Does the problem resolve itself if you change:

     [AS_IF([test "x$XCONFIGURE" != "xandroid" \
             && test "$with_android" = "no"],
       [(movemail --version) >/dev/null 2>&1 || with_mailutils=no],


to read

     [AS_IF([test "x$XCONFIGURE" != "xandroid"],
       [(movemail --version) >/dev/null 2>&1 || with_mailutils=no],

?

bug#65190: 30.0.50; Emacs doesn't build with `--with-mailutils` by default when mailutils is installed on macOS

[Mou Tong]

Thx for the quick response, here is the modification:

```diff
--- a/configure.ac
+++ b/configure.ac
@@ -347,8 +347,10 @@ AC_DEFUN
   [],
   [with_mailutils=$with_features
    AS_IF([test "$with_mailutils" = yes],
-     [AS_IF([test "x$XCONFIGURE" != "xandroid" \
-             && test "$with_android" = "no"],
+     dnl [AS_IF([test "x$XCONFIGURE" != "xandroid" \
+     dnl         && test "$with_android" = "no"],
+     dnl   [(movemail --version) >/dev/null 2>&1 || with_mailutils=no],
+     [AS_IF([test "x$XCONFIGURE" != "xandroid"],
        [(movemail --version) >/dev/null 2>&1 || with_mailutils=no],
        [dnl Don't check for movemail if cross-compiling.
         dnl instead, default to false.
```

But the problem still exists.

bug#65190: 30.0.50; Emacs doesn't build with `--with-mailutils` by default when mailutils is installed on macOS

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Mou Tong <mou.tong@outlook.com> writes:

> Thx for the quick response, here is the modification:
>
> ```diff
> --- a/configure.ac
> +++ b/configure.ac
> @@ -347,8 +347,10 @@ AC_DEFUN
>    [],
>    [with_mailutils=$with_features
>     AS_IF([test "$with_mailutils" = yes],
> -     [AS_IF([test "x$XCONFIGURE" != "xandroid" \
> -             && test "$with_android" = "no"],
> +     dnl [AS_IF([test "x$XCONFIGURE" != "xandroid" \
> +     dnl         && test "$with_android" = "no"],
> +     dnl   [(movemail --version) >/dev/null 2>&1 || with_mailutils=no],
> +     [AS_IF([test "x$XCONFIGURE" != "xandroid"],
>         [(movemail --version) >/dev/null 2>&1 || with_mailutils=no],
>         [dnl Don't check for movemail if cross-compiling.
>          dnl instead, default to false.
> ```
>
> But the problem still exists.

What if you try moving:

AC_ARG_WITH([mailutils],
  [AS_HELP_STRING([--with-mailutils],
     [rely on GNU Mailutils, so that the --without-pop through --with-mailhost
      options are irrelevant; this is the default if GNU Mailutils is
      installed])],
  [],
  [with_mailutils=$with_features
   AS_IF([test "$with_mailutils" = yes],
     [AS_IF([test "x$XCONFIGURE" != "xandroid" \
             && test "$with_android" = "no"],
       [(movemail --version) >/dev/null 2>&1 || with_mailutils=no],
       [dnl Don't check for movemail if cross-compiling.
        dnl instead, default to false.
        with_mailutils=no])])])
AS_IF([test "$with_mailutils" = no],
  [with_mailutils=])

AS_IF([test x"$with_mailutils" = xyes],
  [AC_DEFINE([HAVE_MAILUTILS], [1],
     [Define to 1 if Emacs was configured with mailutils])])

AC_SUBST([with_mailutils])

AC_ARG_WITH([pop],
  [AS_HELP_STRING([--with-pop],
     [Support POP mail retrieval if Emacs movemail is used (not recommended,
      as Emacs movemail POP is insecure).  This is the default only on
      native MS-Windows and Android.])],
  [],
  dnl Enable movemail POP support on Android as GNU Mailutils is
  dnl normally unavailable on that platform.
  [AS_CASE([$host],
     [*-mingw*|*android*], [with_pop=yes],
     [with_pop=no-by-default])])
if test "$with_pop" = yes; then
   AC_DEFINE([MAIL_USE_POP])
fi
AH_TEMPLATE([MAIL_USE_POP], [Define to support POP mail retrieval.])dnl

to below:

OPTION_DEFAULT_OFF([android],[cross-compile Android application package])
OPTION_DEFAULT_ON([android-debug],[don't build Emacs as a debug package on Android])

?  Does that resolve the problem?

Thanks.

bug#65190: 30.0.50; Emacs doesn't build with `--with-mailutils` by default when mailutils is installed on macOS

[Mou Tong]

Ah, sorry.  I forgot to run `./autogen.sh` again to generate a new
`configure`.

After change `configure.ac` like you said before, and exec
`./autogen.sh` to generate a new `configure`. Running `./configure`
works as I expected.

Po Lu <luangruo@yahoo.com> writes：

> Does the problem resolve itself if you change:
>
>     [AS_IF([test "x$XCONFIGURE" != "xandroid" \
>             && test "$with_android" = "no"],
>       [(movemail --version) >/dev/null 2>&1 || with_mailutils=no],
>
>
> to read
>
>     [AS_IF([test "x$XCONFIGURE" != "xandroid"],
>       [(movemail --version) >/dev/null 2>&1 || with_mailutils=no],
>
> ?

This had solved the problem ;)

bug#65190: 30.0.50; Emacs doesn't build with `--with-mailutils` by default when mailutils is installed on macOS

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Mou Tong <mou.tong@outlook.com> writes:

> Ah, sorry.  I forgot to run `./autogen.sh` again to generate a new
> `configure`.
>
> After change `configure.ac` like you said before, and exec
> `./autogen.sh` to generate a new `configure`. Running `./configure`
> works as I expected.
>
> Po Lu <luangruo@yahoo.com> writes：
>
>> Does the problem resolve itself if you change:
>>
>>     [AS_IF([test "x$XCONFIGURE" != "xandroid" \
>>             && test "$with_android" = "no"],
>>       [(movemail --version) >/dev/null 2>&1 || with_mailutils=no],
>>
>>
>> to read
>>
>>     [AS_IF([test "x$XCONFIGURE" != "xandroid"],
>>       [(movemail --version) >/dev/null 2>&1 || with_mailutils=no],
>>
>> ?
>
> This had solved the problem ;)

I fixed this differently.  Would you please pull from master and ack?

bug#65190: 30.0.50; Emacs doesn't build with `--with-mailutils` by default when mailutils is installed on macOS

[Mou Tong]

Po Lu <luangruo@yahoo.com> writes：

> I fixed this differently.  Would you please pull from master and ack?

I pulled the latest commit cc6fed326aa491f89cad5cf59f4a8fb7b2863011
and it worked fine on my machine :)

bug#65190: 30.0.50; Emacs doesn't build with `--with-mailutils` by default when mailutils is installed on macOS

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Mou Tong <mou.tong@outlook.com> writes:

> Po Lu <luangruo@yahoo.com> writes：
>
>> I fixed this differently.  Would you please pull from master and ack?
>
> I pulled the latest commit cc6fed326aa491f89cad5cf59f4a8fb7b2863011
> and it worked fine on my machine :)

Thanks, closing.