* bug#7242: `read-color' and `facemenu-read-color' redundant-p
@ 2010-10-18 18:40 MON KEY
2010-10-24 18:44 ` Chong Yidong
0 siblings, 1 reply; 3+ messages in thread
From: MON KEY @ 2010-10-18 18:40 UTC (permalink / raw)
To: 7242
lisp/faces.el defines `read-color'
lisp/facemenu.el defines `facemenu-read-color'.
Is the functionality of the two sufficiently similar that `read-color' can
be used in lieu of `facemenu-read-color'?
If not, maybe the two fncn's should be merged...
--
/s_P\
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#7242: `read-color' and `facemenu-read-color' redundant-p
2010-10-18 18:40 bug#7242: `read-color' and `facemenu-read-color' redundant-p MON KEY
@ 2010-10-24 18:44 ` Chong Yidong
2010-10-24 19:46 ` Drew Adams
0 siblings, 1 reply; 3+ messages in thread
From: Chong Yidong @ 2010-10-24 18:44 UTC (permalink / raw)
To: MON KEY; +Cc: 7242
MON KEY <monkey@sandpframing.com> writes:
> lisp/faces.el defines `read-color'
> lisp/facemenu.el defines `facemenu-read-color'.
>
> Is the functionality of the two sufficiently similar that `read-color' can
> be used in lieu of `facemenu-read-color'?
>
> If not, maybe the two fncn's should be merged...
Yeah, the introduction of read-color seems like an oversight.
I've merged the two functions, and renamed the result into `read-color'.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#7242: `read-color' and `facemenu-read-color' redundant-p
2010-10-24 18:44 ` Chong Yidong
@ 2010-10-24 19:46 ` Drew Adams
0 siblings, 0 replies; 3+ messages in thread
From: Drew Adams @ 2010-10-24 19:46 UTC (permalink / raw)
To: 'Chong Yidong', 'MON KEY'; +Cc: 7242
> Yeah, the introduction of read-color seems like an oversight.
>
> I've merged the two functions, and renamed the result into
> `read-color'.
See http://lists.gnu.org/archive/html/emacs-devel/2008-10/msg00474.html.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-24 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-18 18:40 bug#7242: `read-color' and `facemenu-read-color' redundant-p MON KEY
2010-10-24 18:44 ` Chong Yidong
2010-10-24 19:46 ` Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).