* bug#6663: #if 0 blocks in source code
@ 2010-07-17 22:10 Christoph
2010-07-22 12:31 ` Juanma Barranquero
0 siblings, 1 reply; 3+ messages in thread
From: Christoph @ 2010-07-17 22:10 UTC (permalink / raw)
To: 6663
I noticed a couple of #if 0 blocks in keyboard.c, which have explicit comments
that the code within the block is obsolete. A quick grep "#if 0" showed
about 200 instances of disabled or obsolete code in files in the src directory.
Should these instances be cleaned up?
Christoph
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#6663: #if 0 blocks in source code
2010-07-17 22:10 bug#6663: #if 0 blocks in source code Christoph
@ 2010-07-22 12:31 ` Juanma Barranquero
2013-02-06 19:13 ` Glenn Morris
0 siblings, 1 reply; 3+ messages in thread
From: Juanma Barranquero @ 2010-07-22 12:31 UTC (permalink / raw)
To: Christoph; +Cc: 6663
On Sun, Jul 18, 2010 at 00:10, Christoph <cschol2112@googlemail.com> wrote:
> I noticed a couple of #if 0 blocks in keyboard.c, which have explicit comments
> that the code within the block is obsolete. A quick grep "#if 0" showed
> about 200 instances of disabled or obsolete code in files in the src directory.
>
> Should these instances be cleaned up?
Not blindly, no.
Some of these code is not obsolete, it's just that it has not been
made to work yet (ISTR there's such code in parts of the w32 image
support, for example, but I could be wrong).
Some of it is indeed obsolete, but (I think) it was felt that having
it around to see would preclude people reinventing tried-and-discarded
ways. That was perhaps more relevant with CVS than Bazaar (or not,
because we still don't have a web interface to easily see past
versions, and relying on bzr blame is clumsy).
In other words, IMHO the answer is that some of these #if 0 blocks
could and should be removed, but you'll have to look at them, exercise
good sense and perhaps ask. Which is why most of them has never been
removed, I suppose :-) Though lately, Dan and Glenn have spearheaded
a big cleanup, so times, they are a-changing.
Juanma
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#6663: #if 0 blocks in source code
2010-07-22 12:31 ` Juanma Barranquero
@ 2013-02-06 19:13 ` Glenn Morris
0 siblings, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2013-02-06 19:13 UTC (permalink / raw)
To: 6663-done
Sorry, I see no value in keeping this report open.
The #if 0s will either decay with time or they wont. Having a bug report
about it won't change anything.
Closing as wontfix.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-06 19:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-17 22:10 bug#6663: #if 0 blocks in source code Christoph
2010-07-22 12:31 ` Juanma Barranquero
2013-02-06 19:13 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).