From: Gregory Heytings <gregory@heytings.org>
To: Alan Mackenzie <acm@muc.de>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>,
48249@debbugs.gnu.org, Dima Kogan <dima@secretsauce.net>
Subject: bug#48249: 28.0.50; Regression: emacs confused about window configuration due to ido-mode and/or winner-mode
Date: Fri, 07 May 2021 12:02:14 +0000 [thread overview]
Message-ID: <9d2af8183143b4650b2a@heytings.org> (raw)
In-Reply-To: <YJUNG7HynPoo89r+@ACM>
>
> diff --git a/lisp/winner.el b/lisp/winner.el
> index f30fa6cf5c..a60ef44662 100644
> --- a/lisp/winner.el
> +++ b/lisp/winner.el
> @@ -212,7 +212,7 @@ winner-set-conf
> (minisize (window-height miniwin)))
> (cl-letf (((window-buffer miniwin))
> ((window-point miniwin)))
> - (set-window-configuration winconf))
> + (set-window-configuration winconf nil t))
> (cond
> ((window-live-p chosen) (select-window chosen))
> ((window-minibuffer-p) (other-window 1)))
>
This cannot be the right way to fix the bug. That line was last changed
more than 20 years ago (commit 2a92dc2540 by RMS).
Or does that mean that from now on each occurrence of
'set-window-configuration' (there are 98 occurrences in the Emacs core
only) should take an additional dont-set-miniwindow t argument to avoid
that bug?
next prev parent reply other threads:[~2021-05-07 12:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 3:50 bug#48249: 28.0.50; Regression: emacs confused about window configuration due to ido-mode and/or winner-mode Dima Kogan
2021-05-06 7:30 ` Gregory Heytings
2021-05-06 8:04 ` Eli Zaretskii
2021-05-06 8:17 ` Gregory Heytings
2021-05-06 9:39 ` Eli Zaretskii
2021-05-06 9:57 ` Gregory Heytings
2021-05-06 10:15 ` Eli Zaretskii
2021-05-06 11:48 ` Gregory Heytings
2021-05-06 12:30 ` Basil L. Contovounesios
2021-05-06 12:39 ` Gregory Heytings
2021-05-06 13:25 ` Basil L. Contovounesios
2021-05-06 13:38 ` Gregory Heytings
2021-05-06 13:58 ` Gregory Heytings
2021-05-06 14:22 ` Basil L. Contovounesios
2021-05-06 14:49 ` Basil L. Contovounesios
2021-05-06 19:25 ` Alan Mackenzie
2021-05-07 9:49 ` Alan Mackenzie
2021-05-07 10:24 ` Basil L. Contovounesios
2021-05-07 12:02 ` Gregory Heytings [this message]
2021-05-07 12:43 ` Alan Mackenzie
2021-05-07 20:30 ` Dima Kogan
2021-05-08 12:30 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d2af8183143b4650b2a@heytings.org \
--to=gregory@heytings.org \
--cc=48249@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=contovob@tcd.ie \
--cc=dima@secretsauce.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).