From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#48249: 28.0.50; Regression: emacs confused about window configuration due to ido-mode and/or winner-mode Date: Fri, 07 May 2021 12:02:14 +0000 Message-ID: <9d2af8183143b4650b2a@heytings.org> References: <87zgx8wmew.fsf@secretsauce.net> <87im3wm4cp.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32415"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Basil L. Contovounesios" , 48249@debbugs.gnu.org, Dima Kogan To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 14:03:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lezCV-0008KD-O5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 14:03:23 +0200 Original-Received: from localhost ([::1]:51946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lezCU-0002OV-Os for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 08:03:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lezCC-0002Md-Nw for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 08:03:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60179) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lezCA-00037j-Aq for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 08:03:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lezCA-0005xX-5R for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 08:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48249 X-GNU-PR-Package: emacs Original-Received: via spool by 48249-submit@debbugs.gnu.org id=B48249.162038893822896 (code B ref 48249); Fri, 07 May 2021 12:03:02 +0000 Original-Received: (at 48249) by debbugs.gnu.org; 7 May 2021 12:02:18 +0000 Original-Received: from localhost ([127.0.0.1]:43490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lezBR-0005xE-Oe for submit@debbugs.gnu.org; Fri, 07 May 2021 08:02:17 -0400 Original-Received: from heytings.org ([95.142.160.155]:41476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lezBP-0005x8-VR for 48249@debbugs.gnu.org; Fri, 07 May 2021 08:02:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1620388934; bh=KrQCrzs+uClT3q8yGhdtnWFeFFX61Nl3D2O5fqzpwmY=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=MOkAGqcJeHYq9m4KIbgWDoBsK1oyLCyd+rptTdCYeELgiXA7PEX2N3bL0sTOPwJIF H/chzopwbse6fDuq/8J78GkO7ftBPso2gCtE3zXo1P+yfN5uWspaBrCxGj0erkVNfZ vNTuQ3XkQRD9a9C16IUwSQpZFFndOwWs+fc9BBphXJgmjdiLMHUOvHjy2xLJM5a0mR GogykcAVYYMozHPS7DXw0xAVDnT3XupeWFlNBN/pghJOr0buoh8rKn6SXWKm7SibB1 7eXJDm/y4eynIGg/NqUPX0vMIorv9rMphmoYfJO37B37jmBbo88657NqE+0t4aBti5 8okfQPTIu4v6Q== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205922 Archived-At: > > diff --git a/lisp/winner.el b/lisp/winner.el > index f30fa6cf5c..a60ef44662 100644 > --- a/lisp/winner.el > +++ b/lisp/winner.el > @@ -212,7 +212,7 @@ winner-set-conf > (minisize (window-height miniwin))) > (cl-letf (((window-buffer miniwin)) > ((window-point miniwin))) > - (set-window-configuration winconf)) > + (set-window-configuration winconf nil t)) > (cond > ((window-live-p chosen) (select-window chosen)) > ((window-minibuffer-p) (other-window 1))) > This cannot be the right way to fix the bug. That line was last changed more than 20 years ago (commit 2a92dc2540 by RMS). Or does that mean that from now on each occurrence of 'set-window-configuration' (there are 98 occurrences in the Emacs core only) should take an additional dont-set-miniwindow t argument to avoid that bug?