unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 62086@debbugs.gnu.org
Subject: bug#62086: 29.0.60; ruby-ts-mode regressions
Date: Wed, 5 Apr 2023 19:36:37 +0300	[thread overview]
Message-ID: <9ceb589f-9325-1607-d1b5-5fd56cb8c3ec@yandex.ru> (raw)
In-Reply-To: <861qkyfg8l.fsf@mail.linkov.net>

On 05/04/2023 19:25, Juri Linkov wrote:
>> There is no mechanism for precedence in the current implementation. We can
>> try ignoring the implicit parens in the parenless method calls,
>> though. Like this:
> I don't know how many users might still want to skip implicit parens.
> Maybe this could be customizable with another list that by default
> includes "argument_list".  It's nice that it's doable with the
> current treesit features.

Calls with both physical and implicit parens have this type.

I'd rather not add user option in advance, let's try to work out what 
looks like the most reasonable behavior, and then add them after 
specific requests.

>> +(defun ruby-ts--sexp-p (node)
>> +  ;; Skip parenless calls (implicit parens are both non-obvious to the
>> +  ;; user, and might take over when we want to just over some physical
>> +  ;; parens/braces).
>> +  (or (not (equal (treesit-node-type node)
>> +                  "argument_list"))
>> +      (equal (treesit-node-type (treesit-node-child node 0))
>> +             "(")))
> Maybe something similar could be used to detect '[' in 'h[:key]'
> to match the corresponding ']'.

It doesn't look like that, no.





  reply	other threads:[~2023-04-05 16:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09 17:24 bug#62086: 29.0.60; ruby-ts-mode regressions Juri Linkov
2023-03-09 18:08 ` Eli Zaretskii
2023-03-10  7:29   ` Juri Linkov
2023-03-09 22:02 ` Dmitry Gutov
2023-03-10  7:35   ` Juri Linkov
2023-03-10 16:37     ` Dmitry Gutov
2023-04-03 16:29   ` Juri Linkov
2023-04-03 20:42     ` Dmitry Gutov
2023-04-04  7:16       ` Juri Linkov
2023-04-05  0:06         ` Dmitry Gutov
2023-04-05  6:24           ` Juri Linkov
2023-04-05 14:58             ` Dmitry Gutov
2023-04-05 16:25               ` Juri Linkov
2023-04-05 16:36                 ` Dmitry Gutov [this message]
2023-04-11 16:53                   ` Juri Linkov
2023-04-11 23:30                     ` Dmitry Gutov
2023-04-12  7:05                       ` Yuan Fu
2023-04-12 15:31                         ` Dmitry Gutov
2023-04-12 20:13                           ` Dmitry Gutov
2023-04-12 21:50                             ` Yuan Fu
2023-04-12 21:56                               ` Dmitry Gutov
2023-04-12 22:11                                 ` Yuan Fu
2023-04-15  0:08                                   ` Yuan Fu
2023-04-13 17:42                             ` Juri Linkov
2023-04-14 17:03                               ` Juri Linkov
2023-04-12  7:30                       ` Eli Zaretskii
2023-04-12 15:31                         ` Dmitry Gutov
2023-04-12 15:40                           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ceb589f-9325-1607-d1b5-5fd56cb8c3ec@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=62086@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).