From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62086: 29.0.60; ruby-ts-mode regressions Date: Wed, 5 Apr 2023 19:36:37 +0300 Message-ID: <9ceb589f-9325-1607-d1b5-5fd56cb8c3ec@yandex.ru> References: <86y1o5op2v.fsf@mail.linkov.net> <5abcf765-f8ce-9563-63aa-20c558409898@yandex.ru> <86cz4l7zjk.fsf@mail.linkov.net> <86ttxww12o.fsf@mail.linkov.net> <865yaakfs7.fsf@mail.linkov.net> <0bd5f2b8-6f0b-09d6-6240-38c742eca19f@yandex.ru> <861qkyfg8l.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34599"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Cc: 62086@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 05 18:37:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pk68N-0008oM-Kv for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Apr 2023 18:37:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pk689-0003EF-FF; Wed, 05 Apr 2023 12:37:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pk687-0003Dj-Pk for bug-gnu-emacs@gnu.org; Wed, 05 Apr 2023 12:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pk686-0004Xd-LF for bug-gnu-emacs@gnu.org; Wed, 05 Apr 2023 12:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pk686-00015M-Gk for bug-gnu-emacs@gnu.org; Wed, 05 Apr 2023 12:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Apr 2023 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62086 X-GNU-PR-Package: emacs Original-Received: via spool by 62086-submit@debbugs.gnu.org id=B62086.16807126084143 (code B ref 62086); Wed, 05 Apr 2023 16:37:02 +0000 Original-Received: (at 62086) by debbugs.gnu.org; 5 Apr 2023 16:36:48 +0000 Original-Received: from localhost ([127.0.0.1]:52531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk67s-00014k-2D for submit@debbugs.gnu.org; Wed, 05 Apr 2023 12:36:48 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:41602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk67p-00014P-Kx for 62086@debbugs.gnu.org; Wed, 05 Apr 2023 12:36:46 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id h17so36800519wrt.8 for <62086@debbugs.gnu.org>; Wed, 05 Apr 2023 09:36:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680712600; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=wMDnoWH4CKOvLHpkARUTbTR6BqFqyUo/82QhTK1K+vg=; b=O4J4q5E5Cu1zsoSxS6ZHzf2WOe2zr25OSVkwcWLc+70fS5vn42RH0GrW7IJ0m519Kg kxu3nQ4i5kjK9ludRkaxS9SzBnvOwGsAdq+aqeN4hKLlUtW1/hu3hijUQN7BAJHNz2SJ zTasEic67Z5Qxn2IqmyS3s+qiuuIjiBmJQToqFFcX4iq1ueBPXvT0cw7dQ4VRtouhNb4 rS1SGiZR5Zlv3x8QYlUAbSzBFUY7a1ZVf1/Nirejzi9hzuntlysXmMcMd99egWWhnbdq LZb17mQcvVQ9gH0pk/KU9ORfA2fmEsGnbBGM39VRMOT0LbOSJlP556Y78y6Y2vAPU2W4 T3uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680712600; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wMDnoWH4CKOvLHpkARUTbTR6BqFqyUo/82QhTK1K+vg=; b=1TONxsvs4qtSzanmB2c4YTBNf/ZXfroCiFHO0GXhis72MRQ9phrQmmS47BqQI4LY1x lEeH412cXXAE7tEcuyIvVyMgvcyZvHUmeQ8/0yvAYArNsgqByDJusSxhcwJrp0/X3QVt z6XGJHY3O9HJ7ufolgocBnXk2bxrWUR/g1OPRvDV8OLb+GE9Q/cUJuTn0vCBbag/bruF SzZcakL2FFPyOIFxhl/m9kEdIc2giXUMVp6wnhFfFBPqfwO9eLgKE3KN3R78nnBlgBVV 9QQka4d2e7Kn7Vey/GkWevJcNaAeraU7odHq2aWWyNwDrPNwDZHrncKCSOSRjNA5ujC/ /dxQ== X-Gm-Message-State: AAQBX9eIOw8DoahYvbMoov/dgR1AuTYCgka3tAHHUTPuwt01ppRTeN9g s8tnv9D+s0xIqY1ga4xcLac= X-Google-Smtp-Source: AKy350Z76t3OH88qpoJFoeayVgOeoRnzHr8eAzhcCuMv4pcZU7FCzi4u4R5Mztvr/yeXIYgtMJJc/A== X-Received: by 2002:a5d:4e4c:0:b0:2ce:a95e:8c77 with SMTP id r12-20020a5d4e4c000000b002cea95e8c77mr4652170wrt.34.1680712599674; Wed, 05 Apr 2023 09:36:39 -0700 (PDT) Original-Received: from [192.168.1.2] ([31.216.80.60]) by smtp.googlemail.com with ESMTPSA id b6-20020a5d5506000000b002e463bd49e3sm15367498wrv.66.2023.04.05.09.36.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Apr 2023 09:36:39 -0700 (PDT) Content-Language: en-US In-Reply-To: <861qkyfg8l.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259280 Archived-At: On 05/04/2023 19:25, Juri Linkov wrote: >> There is no mechanism for precedence in the current implementation. We can >> try ignoring the implicit parens in the parenless method calls, >> though. Like this: > I don't know how many users might still want to skip implicit parens. > Maybe this could be customizable with another list that by default > includes "argument_list". It's nice that it's doable with the > current treesit features. Calls with both physical and implicit parens have this type. I'd rather not add user option in advance, let's try to work out what looks like the most reasonable behavior, and then add them after specific requests. >> +(defun ruby-ts--sexp-p (node) >> + ;; Skip parenless calls (implicit parens are both non-obvious to the >> + ;; user, and might take over when we want to just over some physical >> + ;; parens/braces). >> + (or (not (equal (treesit-node-type node) >> + "argument_list")) >> + (equal (treesit-node-type (treesit-node-child node 0)) >> + "("))) > Maybe something similar could be used to detect '[' in 'h[:key]' > to match the corresponding ']'. It doesn't look like that, no.