unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: 58844@debbugs.gnu.org
Subject: bug#58844: 29.0.50; Font lock features for js/ts-mode
Date: Fri, 28 Oct 2022 12:55:01 -0700	[thread overview]
Message-ID: <9D349316-6AA2-4A5C-8010-110100F3EDB5@gmail.com> (raw)
In-Reply-To: <87ilk3rbp5.fsf@thornhill.no>



> On Oct 28, 2022, at 12:27 PM, Theodor Thornhill <theo@thornhill.no> wrote:
> 
> Hi Yuan!
> 
> I've added more font lock features to the js and ts modes.  I think they
> can serve as a suitable starting point for the features, and serve as
> inspiration to other modes, until we settle on a standard here.
> 
> Thanks,
> 
> Theo
> 
> <0001-Add-in-new-font-lock-features-in-js-ts-mode.patch>

Thanks! Minor bikeshed: I think singular is slightly better. Ie, comment instead of comments. No need to modify your patch, if you agree I can change them myself. Also treesit-font-lock-feature-list should contain three sublist, each representing a decoration level, that’s how we get two types of customization in the same time. I can fix that too.

While we’re at it, are there specific reasons why you write many indent rules in two lines, like this:

((parent-is "ternary_expression")
      parent-bol ,ts-mode-indent-offset)

?

I think they should be in one line for clarity and space efficiency.

Yuan




  reply	other threads:[~2022-10-28 19:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 19:27 bug#58844: 29.0.50; Font lock features for js/ts-mode Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-28 19:55 ` Yuan Fu [this message]
2022-10-28 19:59   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-28 20:25     ` Yuan Fu
2022-11-12 20:45       ` Stefan Kangas
2022-11-12 20:55         ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-12 21:11           ` Stefan Kangas
2022-11-14  9:15             ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9D349316-6AA2-4A5C-8010-110100F3EDB5@gmail.com \
    --to=casouri@gmail.com \
    --cc=58844@debbugs.gnu.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).