From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#58844: 29.0.50; Font lock features for js/ts-mode Date: Fri, 28 Oct 2022 12:55:01 -0700 Message-ID: <9D349316-6AA2-4A5C-8010-110100F3EDB5@gmail.com> References: <87ilk3rbp5.fsf@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20303"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58844@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 28 21:56:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooVSk-000503-PE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Oct 2022 21:56:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooVSc-0004ka-4m; Fri, 28 Oct 2022 15:56:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooVSZ-0004kE-Ku for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 15:56:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooVSU-0000oh-KR for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 15:56:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ooVSU-0002rp-Bw for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 15:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Oct 2022 19:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58844 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: Bug Report Emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.166698691310961 (code B ref -1); Fri, 28 Oct 2022 19:56:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Oct 2022 19:55:13 +0000 Original-Received: from localhost ([127.0.0.1]:34346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooVRh-0002qj-4m for submit@debbugs.gnu.org; Fri, 28 Oct 2022 15:55:13 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:54182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooVRf-0002qb-1T for submit@debbugs.gnu.org; Fri, 28 Oct 2022 15:55:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooVRc-0004bW-Lw for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 15:55:09 -0400 Original-Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooVRZ-0000kY-7U for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 15:55:06 -0400 Original-Received: by mail-pg1-x530.google.com with SMTP id h2so5721706pgp.4 for ; Fri, 28 Oct 2022 12:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BSFQrBip46/mpuDZVec8rS7lzorSKzFxK1MPt8Vqj8Q=; b=HggGwQiMcsTv5zy24LhwmrUSxCJV3d76HGL/oNWOzn8swWSNXnXCGk9dC2gu1RqgT4 vRLgWw3vsRlBMY4uoEystIlH0UrZA4Bj6rkb5hjab+d9TfUm5iowC9HjooLWfbZL+WWz g12Y6QkMhoZfJPCqQAqBhBU0OJB404ZeEkYWhP5lxyz5ceVEaErOoGwhzJ62Nm1LuvvB VbbWHDpKYXIJbv8bTsMaK6R/briSd3bnuA1lpTjB8+ect0jyXJRB8tpMTc0hA/Q4hOar o4JOFVUEtWU7jY6yzFaSwpjR3X0jn5IpkxwBLOk/q10wa92C8KCmGPSeds42zHFLPGfM o36A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BSFQrBip46/mpuDZVec8rS7lzorSKzFxK1MPt8Vqj8Q=; b=T3IkUnsIqTu5wk0CTQs0o1/Gt/GI/nAivaUdY92m2jWoOFMsVp8gIuU3CPxOZRcin9 2wytGi/Vb72mu4qvo/gMMbwysTbMsac/bg1K6FvF7Dws3Q5d++shNMIW2GFAPG6vP5mO +GcNoajjZ2yAYOd2PFe0lzJd1cKOtmPGypJNsbCIH/5k7xId4ccbieD84+C/UEHZ22za rmR54glqM/Dpi9WkxMlzq9L4BMZEV+NjJFc/6zRW5JYUAeapLsG01p0SKacGc/cx1sEY X7Vj8mrQcQpQDdJfdlnipKyzx3lwvET83ab08/84n2q5hrndLsXaNOPig2eeYiOwmJa2 kGDQ== X-Gm-Message-State: ACrzQf12UAHDO3mbfDC68+vwjBu6Im+wMo9LP4yOPczK8eyPWM6Ga4oW DTh5zA8z3BmkogRSXyJGhMo= X-Google-Smtp-Source: AMsMyM6zLaPXlRv/XHGHCFxSclv4Q9I3l6iXm85m+Eamc9xHwYCFLyyOqymU39W9ZdB0gwUiwukh+Q== X-Received: by 2002:a63:d551:0:b0:452:87e0:73d5 with SMTP id v17-20020a63d551000000b0045287e073d5mr997085pgi.488.1666986903554; Fri, 28 Oct 2022 12:55:03 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id lt20-20020a17090b355400b00212e5068e17sm2890392pjb.40.2022.10.28.12.55.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2022 12:55:03 -0700 (PDT) In-Reply-To: <87ilk3rbp5.fsf@thornhill.no> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=casouri@gmail.com; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246453 Archived-At: > On Oct 28, 2022, at 12:27 PM, Theodor Thornhill = wrote: >=20 > Hi Yuan! >=20 > I've added more font lock features to the js and ts modes. I think = they > can serve as a suitable starting point for the features, and serve as > inspiration to other modes, until we settle on a standard here. >=20 > Thanks, >=20 > Theo >=20 > <0001-Add-in-new-font-lock-features-in-js-ts-mode.patch> Thanks! Minor bikeshed: I think singular is slightly better. Ie, comment = instead of comments. No need to modify your patch, if you agree I can = change them myself. Also treesit-font-lock-feature-list should contain = three sublist, each representing a decoration level, that=E2=80=99s how = we get two types of customization in the same time. I can fix that too. While we=E2=80=99re at it, are there specific reasons why you write many = indent rules in two lines, like this: ((parent-is "ternary_expression") parent-bol ,ts-mode-indent-offset) ? I think they should be in one line for clarity and space efficiency. Yuan=