unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>,
	Daniel Colascione <dan.colascione@gmail.com>
Cc: dino chiesa <dpchiesa@hotmail.com>, 8724@debbugs.gnu.org
Subject: bug#8724: 23.2; js-mode imenu should be more thorough
Date: Sat, 5 Jun 2021 03:24:41 +0300	[thread overview]
Message-ID: <96de25bd-511a-67c7-9253-1e7e29b1e021@yandex.ru> (raw)
In-Reply-To: <87y2bselz9.fsf@gnus.org>

On 02.06.2021 10:58, Lars Ingebrigtsen wrote:
> This was nine years ago -- was there any progress with this?  (It sounds
> like a good change, but I haven't looked at the code.)

Someone should really work in that direction, since in these nine years 
JS has grown more ways to define a function: e.g. arrow functions, or 
'const <function name> = ...'.

I've tried simply replacing the definition.

The patch kinda works, except I'm not sure about the (top) and (bottom) 
items that it adds (we don't have any precedent for this, so I vote no), 
and there's some sort of duplication of the entries: I see both (top) 
and the enclosed function name repeated an extra time in the imenu index.





  reply	other threads:[~2021-06-05  0:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 12:51 bug#8724: 23.2; js-mode imenu should be more thorough dino chiesa
2011-06-19 20:40 ` Daniel Colascione
2021-06-02  7:58   ` Lars Ingebrigtsen
2021-06-05  0:24     ` Dmitry Gutov [this message]
2024-01-10 11:55       ` Stefan Kangas
2024-01-11  0:19         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96de25bd-511a-67c7-9253-1e7e29b1e021@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=8724@debbugs.gnu.org \
    --cc=dan.colascione@gmail.com \
    --cc=dpchiesa@hotmail.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).