From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#8724: 23.2; js-mode imenu should be more thorough Date: Sat, 5 Jun 2021 03:24:41 +0300 Message-ID: <96de25bd-511a-67c7-9253-1e7e29b1e021@yandex.ru> References: <4DFE5EC4.3070103@gmail.com> <87y2bselz9.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38243"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: dino chiesa , 8724@debbugs.gnu.org To: Lars Ingebrigtsen , Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 05 02:25:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpK7i-0009nh-Ri for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Jun 2021 02:25:10 +0200 Original-Received: from localhost ([::1]:34668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpK7h-00066T-CD for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Jun 2021 20:25:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpK7a-00066D-Ff for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 20:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpK7a-0002wT-97 for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 20:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lpK7a-0005ug-3n for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 20:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Jun 2021 00:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8724 X-GNU-PR-Package: emacs Original-Received: via spool by 8724-submit@debbugs.gnu.org id=B8724.162285269122712 (code B ref 8724); Sat, 05 Jun 2021 00:25:02 +0000 Original-Received: (at 8724) by debbugs.gnu.org; 5 Jun 2021 00:24:51 +0000 Original-Received: from localhost ([127.0.0.1]:48071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpK7P-0005uG-B0 for submit@debbugs.gnu.org; Fri, 04 Jun 2021 20:24:51 -0400 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:45760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpK7N-0005u2-Jc for 8724@debbugs.gnu.org; Fri, 04 Jun 2021 20:24:50 -0400 Original-Received: by mail-wm1-f44.google.com with SMTP id v206-20020a1cded70000b02901a586d3fa23so2201255wmg.4 for <8724@debbugs.gnu.org>; Fri, 04 Jun 2021 17:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=964VyqOXVoQoHGuaSR7YRMR0e4TsIoP0WnwULqXZPEY=; b=jPNdKEt/if9HxfymZpCJiOhnDCX31SHomY53PkbhQggUem9d1uLVkiwIu/K2SFjhDV mWS8nACEJaZxgzxJJOZMGBcVyqc2iQFmWwF7fqkuIEt0CjH0CkxGYwxKDhxXu8EOiLc5 ma0SvDhQXuZZ8zwQeuIjhmxWXE8eRyscQKbSv26IelpWTWEE/34r9PEccxDb9oKGdqfA 2OwM3w/pgpQ8pv45DD5ViOL1gKiqj9XAlqCXvtfuXXS1hE4jE077wZNC9Bc+o0hggMsM RKXX1rsymg6DySn+RurGNNSo6IMHdlV/B73VVrxEgUFiaQjcI8mUJ+eYmgokQm6zMLrB lEbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=964VyqOXVoQoHGuaSR7YRMR0e4TsIoP0WnwULqXZPEY=; b=X8nLKl3JvNU3LK/SJZ9ANc4WMsXCtg+w9s/whUg1fzSLYZn6KSD2ABOXk4iNVbXSUN C2PKV451enNZIuGZ52CfJUrFPSZA5ZmvGf4vThQo1stjQynag04f1CX+tVHEZXyGyAHq ar5Fs3tVaevluPjHUtL200e9e49QXeSx7QmudWkmkmNgJSwK9LvlzKgjMxkww8V8A1ka SM3T0eSixlwi3qY/Hza+FvmsZbskGae6523TZUiOrpz2HVg7Ubl4+4BUUc4n7qI9x84B i6hJtETmBqrQ5Dk7gld/xjO3wWpx2/8uJKUDxnUSXKNw8NIWlVh5bUK1TLDoIZWSC80d vbvQ== X-Gm-Message-State: AOAM532IIKhvz+/uvQKkr3VYrPs9hOlWU5DeUA64gi53AlwUg7m4t9ug b+t9fU2qEdnvIY4c1PKEGz3G5WWqis8= X-Google-Smtp-Source: ABdhPJzCoPVmPI7iDitrQBZOApdyZAIXz5Bi2OZuA8FBex5YO353hNKBc11DYPYXJULoGpCnnq7kkQ== X-Received: by 2002:a7b:c1c5:: with SMTP id a5mr5991367wmj.134.1622852683481; Fri, 04 Jun 2021 17:24:43 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id u18sm6869326wmj.15.2021.06.04.17.24.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jun 2021 17:24:42 -0700 (PDT) In-Reply-To: <87y2bselz9.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208041 Archived-At: On 02.06.2021 10:58, Lars Ingebrigtsen wrote: > This was nine years ago -- was there any progress with this? (It sounds > like a good change, but I haven't looked at the code.) Someone should really work in that direction, since in these nine years JS has grown more ways to define a function: e.g. arrow functions, or 'const = ...'. I've tried simply replacing the definition. The patch kinda works, except I'm not sure about the (top) and (bottom) items that it adds (we don't have any precedent for this, so I vote no), and there's some sort of duplication of the entries: I see both (top) and the enclosed function name repeated an extra time in the imenu index.