bug#3999: [PATCH] incorrect main and mini-buffer window size in 23.1 RC (more apparent in full screen mode)

bug#3999: [PATCH] incorrect main and mini-buffer window size in 23.1 RC (more apparent in full screen mode)

[janmejay singh]

[-- Attachment #1.1: Type: text/plain, Size: 422 bytes --]

Hi,

Have been observing this bug since tag named EMACS_PRETEST_23_0_94 was
created.

This patch fixes it on branch named EMACS_23_1_RC

The problem is not reproducible on master, its reproducible only on tags
EMACS_PRETEST_23_0_94(and higher) and on branch EMACS_23_1_RC.

Please drop me a mail if screen-shots and detailed description of this
problem are required.

-- 
Regards,
Janmejay
(http://codehunk.wordpress.com)

[-- Attachment #1.2: Type: text/html, Size: 531 bytes --]

[-- Attachment #2: emacs_window_size_in_fullscreen_frame_fix.patch --]
[-- Type: text/x-patch, Size: 771 bytes --]

From 7aca07c7aaa703eff39da17a8aecf86bc4d62449 Mon Sep 17 00:00:00 2001
From: Janmejay Singh <singh.janmejay@gmail.com>
Date: Fri, 31 Jul 2009 19:15:34 +0530
Subject: fix to emacs not setting correct mini-buffer window size and frame size when started in full-screen mode (with -fs)

---
 src/gtkutil.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/gtkutil.c b/src/gtkutil.c
index 3ea7c14..7981f98 100644
--- a/src/gtkutil.c
+++ b/src/gtkutil.c
@@ -750,7 +750,7 @@ xg_frame_set_char_size (f, cols, rows)
 
      We pass 1 for DELAY since we can't run Lisp code inside of
      a BLOCK_INPUT.  */
-  change_frame_size (f, rows, cols, 0, 1, 0);
+
   FRAME_PIXEL_WIDTH (f) = pixelwidth;
   FRAME_PIXEL_HEIGHT (f) = pixelheight;
 
-- 
1.5.6.5

bug#3999: marked as done ([PATCH] incorrect main and mini-buffer window size in 23.1 RC (more apparent in full screen mode))

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]


Your message dated Sun, 02 Aug 2009 19:26:13 -0400
with message-id <87eirt6bmy.fsf@cyd.mit.edu>
and subject line [PATCH] incorrect main and mini-buffer window size in 23.1 RC (more apparent in full screen mode)
has caused the Emacs bug report #3999,
regarding [PATCH] incorrect main and mini-buffer window size in 23.1 RC (more  apparent in full screen mode)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3999: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3999
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5591 bytes --]

[-- Attachment #2.1.1.1: Type: text/plain, Size: 422 bytes --]

Hi,

Have been observing this bug since tag named EMACS_PRETEST_23_0_94 was
created.

This patch fixes it on branch named EMACS_23_1_RC

The problem is not reproducible on master, its reproducible only on tags
EMACS_PRETEST_23_0_94(and higher) and on branch EMACS_23_1_RC.

Please drop me a mail if screen-shots and detailed description of this
problem are required.

-- 
Regards,
Janmejay
(http://codehunk.wordpress.com)

[-- Attachment #2.1.1.2: Type: text/html, Size: 531 bytes --]

[-- Attachment #2.1.2: emacs_window_size_in_fullscreen_frame_fix.patch --]
[-- Type: text/x-patch, Size: 771 bytes --]

From 7aca07c7aaa703eff39da17a8aecf86bc4d62449 Mon Sep 17 00:00:00 2001
From: Janmejay Singh <singh.janmejay@gmail.com>
Date: Fri, 31 Jul 2009 19:15:34 +0530
Subject: fix to emacs not setting correct mini-buffer window size and frame size when started in full-screen mode (with -fs)

---
 src/gtkutil.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/gtkutil.c b/src/gtkutil.c
index 3ea7c14..7981f98 100644
--- a/src/gtkutil.c
+++ b/src/gtkutil.c
@@ -750,7 +750,7 @@ xg_frame_set_char_size (f, cols, rows)
 
      We pass 1 for DELAY since we can't run Lisp code inside of
      a BLOCK_INPUT.  */
-  change_frame_size (f, rows, cols, 0, 1, 0);
+
   FRAME_PIXEL_WIDTH (f) = pixelwidth;
   FRAME_PIXEL_HEIGHT (f) = pixelheight;
 
-- 
1.5.6.5


[-- Attachment #3: Type: message/rfc822, Size: 1498 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: janmejay singh <singh.janmejay@gmail.com>
Cc: 3999-done@emacsbugs.donarmstrong.com
Subject: [PATCH] incorrect main and mini-buffer window size in 23.1 RC (more apparent in full screen mode)
Date: Sun, 02 Aug 2009 19:26:13 -0400
Message-ID: <87eirt6bmy.fsf@cyd.mit.edu>

> Have been observing this bug since tag named EMACS_PRETEST_23_0_94 was
> created.
>
> This patch fixes it on branch named EMACS_23_1_RC
>
> The problem is not reproducible on master, its reproducible only on tags
> EMACS_PRETEST_23_0_94(and higher) and on branch EMACS_23_1_RC.

Thanks.  As you noted, the code in the trunk has been revised, making
this patch unnecessary.