bug#4230: 23.1; bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate

bug#4230: 23.1; bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate

[Drew Adams]

From the definition of bookmark-handle-bookmark:
 
(let ((file (bookmark-get-filename bookmark)))
         (when file        ;Don't know how to relocate if there's no `file'.
           (setq file (expand-file-name file))
           (ding)
           (if (y-or-n-p (concat (file-name-nondirectory file)
                                 " nonexistent.  Relocate \""
                                 bookmark
                                 "\"? "))
               ...
 
A bookmark can be to a directory or a file. AFAICT, at least on
Windows, you cannot choose a directory using a file selection box - it
insists on a file. Or perhaps there is another kind of file selection
box that allows this, but it is not being used by Emacs.
 
So `use-file-dialog' should be bound to nil around the call to
`y-or-n-p'.
 
I had a bookmark to a directory that needed to be relocated. I tried
to jump to the bookmark by clicking it with the mouse in the list from
`C-x r l'. Because I used the mouse, I got the file dialog box. I
could not find a way to specify a new directory - choosing a directory
just opens the dialog box to the files in the directory, waiting for
you to pick one.
 
 
 

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
 

bug#4230: marked as done (23.1; bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

Your message dated Sun, 04 Oct 2009 22:39:38 -0400
with message-id <87k4zamumt.fsf@red-bean.com>
and subject line Fixed "bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate"
has caused the Emacs bug report #4230,
regarding 23.1; bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4230: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4230
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4114 bytes --]

From: "Drew Adams" <drew.adams@oracle.com>
To: <bug-gnu-emacs@gnu.org>
Subject: 23.1; bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate
Date: Fri, 21 Aug 2009 15:45:19 -0700
Message-ID: <95DE0F7C73CE4F63AAE1BEA19D46D5AA@us.oracle.com>

From the definition of bookmark-handle-bookmark:
 
(let ((file (bookmark-get-filename bookmark)))
         (when file        ;Don't know how to relocate if there's no `file'.
           (setq file (expand-file-name file))
           (ding)
           (if (y-or-n-p (concat (file-name-nondirectory file)
                                 " nonexistent.  Relocate \""
                                 bookmark
                                 "\"? "))
               ...
 
A bookmark can be to a directory or a file. AFAICT, at least on
Windows, you cannot choose a directory using a file selection box - it
insists on a file. Or perhaps there is another kind of file selection
box that allows this, but it is not being used by Emacs.
 
So `use-file-dialog' should be bound to nil around the call to
`y-or-n-p'.
 
I had a bookmark to a directory that needed to be relocated. I tried
to jump to the bookmark by clicking it with the mouse in the list from
`C-x r l'. Because I used the mouse, I got the file dialog box. I
could not find a way to specify a new directory - choosing a directory
just opens the dialog box to the files in the directory, waiting for
you to pick one.
 
 
 

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
 




[-- Attachment #3: Type: message/rfc822, Size: 1724 bytes --]

From: Karl Fogel <kfogel@red-bean.com>
To: 4230-close@emacsbugs.donarmstrong.com
Subject: Fixed "bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate"
Date: Sun, 04 Oct 2009 22:39:38 -0400
Message-ID: <87k4zamumt.fsf@red-bean.com>

fixed
--

Thanks for the report.  Fix committed; please test this, as I do not
have a Windows system myself to test it on.

  $ cvs ci -F msg lisp/bookmark.el lisp/ChangeLog
  /sources/emacs/emacs/lisp/bookmark.el,v  <--  lisp/bookmark.el
  new revision: 1.130; previous revision: 1.129
  /sources/emacs/emacs/lisp/ChangeLog,v  <--  lisp/ChangeLog
  new revision: 1.16356; previous revision: 1.16355
  Mailing notification to emacs-diffs@gnu.org... sent.
  $