bug#33746: 26.1; ada-mode 6.0.0 indentation of comments in a case statement

bug#33746: 26.1; ada-mode 6.0.0 indentation of comments in a case statement

[Ludovic Brenta]

Package: emacs, ada-mode
X-Debbugs-CC: ada-mode-users@nongnu.org

Hello,

Here is another minor indentation bug in ada-mode 6.0.0; note how
the indentation of the two comments is inconsistent:

procedure When_Indentation is
begin
   case A is
     when B =>
       -- This comment is indented correctly
       Foo;
     -- This comment is indented incorrectly: should be as above
   end case;
end When_Indentation;

-- 
Ludovic Brenta.

bug#33746: [Ada-mode-users] bug#33746: 26.1; ada-mode 6.0.0 indentation of comments in a case statement

[Simon Wright]

[-- Attachment #1: Type: text/plain, Size: 795 bytes --]

On 14 Dec 2018, at 17:22, Ludovic Brenta <ludovic@ludovic-brenta.org> wrote:
> 
> Package: emacs, ada-mode
> X-Debbugs-CC: ada-mode-users@nongnu.org
> 
> Hello,
> 
> Here is another minor indentation bug in ada-mode 6.0.0; note how
> the indentation of the two comments is inconsistent:
> 
> procedure When_Indentation is
> begin
>  case A is
>    when B =>
>      -- This comment is indented correctly
>      Foo;
>    -- This comment is indented incorrectly: should be as above
>  end case;
> end When_Indentation;

GPS goes too far the other way if you select (what was for me) the default, Indent comments => unchecked, Align comments on keywords checked; the same with both unchecked. ludo-problems.adb.

If I check just Indent comments, I get ludo-problems-2.adb.


[-- Attachment #2: ludo-problems.adb --]
[-- Type: application/octet-stream, Size: 640 bytes --]

procedure Comment_Indentation is
begin
   if A
     -- This comment is indented correctly
     and then B
       -- This comment is indented incorrectly, should be as above
   then
      -- This comment is indented correctly
      null;
   elsif C
     -- This comment is indented correctly
     and then D
       -- This comment is indented incorrectly, should be as above
   then
      null;
   end if;
end Comment_Indentation;

procedure When_Indentation is
begin
   case A is
      when B =>
	 -- This comment is indented correctly
	 Foo;
	 -- This comment is indented incorrectly: should be as above
   end case;
end When_Indentation;

[-- Attachment #3: ludo-problems-2.adb --]
[-- Type: application/octet-stream, Size: 649 bytes --]

procedure Comment_Indentation is
begin
   if A
   -- This comment is indented correctly
     and then B
   -- This comment is indented incorrectly, should be as above
   then
      -- This comment is indented correctly
      null;
   elsif C
   -- This comment is indented correctly
     and then D
   -- This comment is indented incorrectly, should be as above
   then
      null;
   end if;
end Comment_Indentation;

procedure When_Indentation is
begin
   case A is
      when B =>
         -- This comment is indented correctly
         Foo;
         -- This comment is indented incorrectly: should be as above
   end case;
end When_Indentation;

[-- Attachment #4: Type: text/plain, Size: 1 bytes --]

bug#33746: update

[Stephen Leake]

Fixed in ada-mode 6.1.0 in GNU ELPA
-- 
-- Stephe

bug#33746: update

[Stephen Leake]

-- 
-- Stephe