bug#47854: debbugs-gnu to not bugs tag as fixed when closing

bug#47854: debbugs-gnu to not bugs tag as fixed when closing

[Glenn Morris]

Package: emacs
Severity: wishlist

I wish debbugs-gnu did not tag bugs as fixed when it closes them.
This is a misuse of the fixed tag, which should only be applied to open bugs.
The purpose of the fixed tag is:
   "This bug is fixed or worked around, but there's still an issue that
    needs to be resolved."

A closed bug can by default be assumed to be fixed, so tagging it fixed
is at best redundant, and most likely a nuisance, since if the bug is
later found to still occur you can't just reopen the report, you have to
remember to untag it as well.

bug#47854: debbugs-gnu to not bugs tag as fixed when closing

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

> I wish debbugs-gnu did not tag bugs as fixed when it closes them.
> This is a misuse of the fixed tag, which should only be applied to open bugs.
> The purpose of the fixed tag is:
>    "This bug is fixed or worked around, but there's still an issue that
>     needs to be resolved."
>
> A closed bug can by default be assumed to be fixed, so tagging it fixed
> is at best redundant, and most likely a nuisance, since if the bug is
> later found to still occur you can't just reopen the report, you have to
> remember to untag it as well.

I tend to agree. Lars?

Best regards, Michael.

bug#47854: debbugs-gnu to not bugs tag as fixed when closing

[Lars Ingebrigtsen]

Michael Albinus <michael.albinus@gmx.de> writes:

>> A closed bug can by default be assumed to be fixed, so tagging it fixed
>> is at best redundant, and most likely a nuisance, since if the bug is
>> later found to still occur you can't just reopen the report, you have to
>> remember to untag it as well.
>
> I tend to agree. Lars?

The "fixed" tag also includes a version it was supposed to be fixed
in...  which seems slightly useful.

And you can reopen without removing the tag.

But I have no strong opinion here -- I don't think anyone actually uses
these tags for anything at present.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#47854: debbugs-gnu to not bugs tag as fixed when closing

[Michael Albinus]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>>> A closed bug can by default be assumed to be fixed, so tagging it fixed
>>> is at best redundant, and most likely a nuisance, since if the bug is
>>> later found to still occur you can't just reopen the report, you have to
>>> remember to untag it as well.
>>
>> I tend to agree. Lars?
>
> The "fixed" tag also includes a version it was supposed to be fixed
> in...  which seems slightly useful.
>
> And you can reopen without removing the tag.

Hmm, if we submit the "reopen" command in debbugs-gnu, the tags "fixed"
and "patch" are removed. Isn't this sufficient?

Alternatively, we could ask interactively, whether a bug shall be marked
as "fixed", when the "close" command is raised in debbugs-gnu.

> But I have no strong opinion here -- I don't think anyone actually uses
> these tags for anything at present.

Indeed.

Best regards, Michael.

bug#47854: debbugs-gnu to not bugs tag as fixed when closing

[Glenn Morris]

Lars Ingebrigtsen wrote:

> The "fixed" tag also includes a version it was supposed to be fixed
> in...  which seems slightly useful.

The fixed tag has no association with the version number that can be
provided when closing a bug. Debbugs tags do not take arguments.
The version information is provided by a "Version" pseudoheader.

bug#47854: debbugs-gnu to not bugs tag as fixed when closing

[Lars Ingebrigtsen]

Glenn Morris <rgm@gnu.org> writes:

> Lars Ingebrigtsen wrote:
>
>> The "fixed" tag also includes a version it was supposed to be fixed
>> in...  which seems slightly useful.
>
> The fixed tag has no association with the version number that can be
> provided when closing a bug. Debbugs tags do not take arguments.
> The version information is provided by a "Version" pseudoheader.

Oh, sorry -- I was confused about where the version went:

        ((equal message "close")
         (format "close %d %s\n" bugid version))
        ((equal message "done")
         (format "tags %d fixed\nclose %d %s\n" bugid bugid version))

Then I guess we can just make close/done synonyms of each other in
debbugs-gnu.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#47854: debbugs-gnu to not bugs tag as fixed when closing

[Michael Albinus]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>>> The "fixed" tag also includes a version it was supposed to be fixed
>>> in...  which seems slightly useful.
>>
>> The fixed tag has no association with the version number that can be
>> provided when closing a bug. Debbugs tags do not take arguments.
>> The version information is provided by a "Version" pseudoheader.
>
> Oh, sorry -- I was confused about where the version went:
>
>         ((equal message "close")
>          (format "close %d %s\n" bugid version))
>         ((equal message "done")
>          (format "tags %d fixed\nclose %d %s\n" bugid bugid version))
>
> Then I guess we can just make close/done synonyms of each other in
> debbugs-gnu.

Indeed, a "fixed" tag doesn't make sense at all. Instead, there is the
"fixed" attribute, which is set either explictly by the "fixed" command,
or implicitly by the "close" command.

I've changed this in debbugs-gnu.el, pushed to the repository. Shall
appear as debbugs 0.28.

Closing the bug.

Best regards, Michael.

bug#47854: debbugs-gnu to not bugs tag as fixed when closing

[Glenn Morris]

Thanks.