bug#9622: 23.3; flet indentation

bug#9622: 23.3; flet indentation

[Diogo F. S. Ramos]

Currently, when using `flet', the functions are indented with respect of
the arglist.

It would be nice if flet functions were indented like a `defun', for
example.

Current behavior:

(defun foo ()
  (flet ((long-function-name ()
                             (misses-flet)))
    (long-function-name)))

Wanted behavior:

(defun foo ()
  (flet ((long-function-name ()
           (hi-flet)))
    (long-function-name)))

-- 
Diogo F. S. Ramos

bug#9622: 23.3; flet indentation

[Stefan Kangas]

diogofsr@gmail.com (Diogo F. S. Ramos) writes:

> Currently, when using `flet', the functions are indented with respect of
> the arglist.
>
> It would be nice if flet functions were indented like a `defun', for
> example.
>
> Current behavior:
>
> (defun foo ()
>   (flet ((long-function-name ()
>                              (misses-flet)))
>     (long-function-name)))
>
> Wanted behavior:
>
> (defun foo ()
>   (flet ((long-function-name ()
>            (hi-flet)))
>     (long-function-name)))

I can confirm that this is still an issue on Emacs 26.2 and current
master.

Thanks,
Stefan Kangas

bug#9622: 23.3; flet indentation

[Lars Ingebrigtsen]

diogofsr@gmail.com (Diogo F. S. Ramos) writes:

> Currently, when using `flet', the functions are indented with respect of
> the arglist.
>
> It would be nice if flet functions were indented like a `defun', for
> example.

This is now fixed in Emacs 28:

commit 57dcc26e4af4e4f7812f2e287f18d36c662bf6b1 (HEAD -> master)
Author:     akater <nuclearspace@gmail.com>
AuthorDate: Sat Sep 25 03:27:29 2021 +0200


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#9622: 23.3; flet indentation

[akater]

[-- Attachment #1: Type: text/plain, Size: 134 bytes --]

I'm not around Emacs 28 atm; could you check if it's still wrong when cl-flet's definition — square (x) — is not on a single line?

[-- Attachment #2: Type: text/html, Size: 175 bytes --]

bug#9622: 23.3; flet indentation

[Lars Ingebrigtsen]

akater <nuclearspace@gmail.com> writes:

> I'm not around Emacs 28 atm; could you check if it's still wrong when
> cl-flet's definition — square (x) — is not on a single line?

Yes, it's still wrongly indented:

(cl-flet ((square (x)
            (* x x)))
  (let* ((a 3)
          (b (square a)))               ; <-- malindented
    b))

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#9622: 23.3; flet indentation

[Mattias Engdegård]

It affects other constructs too:

  (cl-flet ((f () alpha))
    (cond
     (beta
       gamma)))  ; <- wrong

bug#9622: 23.3; flet indentation

[Mattias Engdegård]

More examples:

  (cl-flet ((f () alpha))
    (let ((x y))
      (if beta
        gamma     ; <- wrong
        delta)))

  (cl-flet ((f () alpha))
    (gamma
     (delta
       epsilon)))   ; <- wrong

bug#9622: 23.3; flet indentation

[akater]

[-- Attachment #1: Type: text/plain, Size: 126 bytes --]

OK I found the culprit; figuring out the least expensive way to
resolve.  One way or another, I'll fix it in the coming days.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

bug#9622: 23.3; flet indentation

[Michael Heerdegen]

akater <nuclearspace@gmail.com> writes:

> Several fixes:
> [...]

Am I allowed to report a regression that might be caused by these
changes here?

I have code like this:

#+begin_src emacs-lisp
(cl-flet* ((cont-w/expr (f) (g-w/extended-expr cont f))
           (cont-prepend (&rest exps)
             (cont-w/expr (lambda (p) (apply #'g--and (append exps (list p)))))))
  (pcase expr
    ((and (let transformed (g--trivial-transformation-p expr)) (guard transformed))
    (cont-prepend transformed))))
#+end_src

and the last line gets indented wrongly (one space too less).  When I
remove the wrapping `cl-flet*' indentation behavior gets back to the
expected.


Michael.