From: Ivan Shmakov <ivan@siamics.net>
To: 18550@debbugs.gnu.org
Subject: bug#18550: eww-history-browse may end up calling eww-restore-history in an arbitrary buffer
Date: Wed, 19 Nov 2014 11:30:16 +0000 [thread overview]
Message-ID: <87zjbn5sxj.fsf@violet.siamics.net> (raw)
In-Reply-To: <m3mw7vdnv4.fsf@stories.gnus.org> (Lars Magne Ingebrigtsen's message of "Thu, 13 Nov 2014 18:14:23 +0100")
>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>> So I guess eww should set up the `quit-restore' thing properly.
>> I'll have a peek.
> Actually, that doesn't provide a way to do this (rather obvious)
> thing.
> Shouldn't there be a way to instruct `quit-window' to go to a
> specific buffer (if that buffer is still alive)?
I see no reason to abuse quit-window for what’s essentially
switching to a buffer to edit one. That is: the
eww-restore-history call right after quit-window edits the
/current/ buffer. Thus, it indeed makes sense to explicitly use
set-buffer before that. (Or to wrap the call in
with-current-buffer, anyway.)
Moreover, vc.el already uses a dedicated buffer-local variable
for a similar purpose, and so does rcirc.el, and perhaps a few
more modes out there.
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
next prev parent reply other threads:[~2014-11-19 11:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 21:19 bug#18550: eww-history-browse may end up calling eww-restore-history in an arbitrary buffer Ivan Shmakov
2014-11-13 17:03 ` Lars Magne Ingebrigtsen
2014-11-13 17:14 ` Lars Magne Ingebrigtsen
2014-11-19 11:30 ` Ivan Shmakov [this message]
2014-11-19 17:25 ` Lars Magne Ingebrigtsen
2014-11-25 15:40 ` Ivan Shmakov
2014-12-07 19:38 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjbn5sxj.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=18550@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).