From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#18550: eww-history-browse may end up calling eww-restore-history in an arbitrary buffer Date: Wed, 19 Nov 2014 11:30:16 +0000 Message-ID: <87zjbn5sxj.fsf@violet.siamics.net> References: <87tx3wn2d0.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1416396684 20031 80.91.229.3 (19 Nov 2014 11:31:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Nov 2014 11:31:24 +0000 (UTC) To: 18550@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 19 12:31:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xr3Ti-0001Lm-90 for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Nov 2014 12:31:18 +0100 Original-Received: from localhost ([::1]:57581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr3Tf-0006Qg-NN for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Nov 2014 06:31:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr3TX-0006PU-KF for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 06:31:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xr3TS-0004Xl-RF for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 06:31:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr3TS-0004Wd-Ja for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 06:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Xr3TR-0007fn-Vt for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 06:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Nov 2014 11:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18550 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18550-submit@debbugs.gnu.org id=B18550.141639663829462 (code B ref 18550); Wed, 19 Nov 2014 11:31:01 +0000 Original-Received: (at 18550) by debbugs.gnu.org; 19 Nov 2014 11:30:38 +0000 Original-Received: from localhost ([127.0.0.1]:37876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xr3T0-0007f2-Be for submit@debbugs.gnu.org; Wed, 19 Nov 2014 06:30:38 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:41369) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xr3Su-0007eo-0S for 18550@debbugs.gnu.org; Wed, 19 Nov 2014 06:30:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=Z3s+WXrhyjh+l5xDMemeudQd4ZyWMjL9RUhfLGWtQBo=; b=r2L0WTw1XHMe4Kzmn+p91P5UOl/VhrR4icjt35cmNnZkXjCZCswGTf8u+mkp0ecf7CTGeeOLmaUdN+ITO+A/GqysGv1PGYCj0OX8ccSlfB4VdBppKBmKrqz5xcGIkc8l4FziJQRoPXD8g53UuCBNJuoT9oWFy9CCBz+3RPpZAq4=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xr3Sr-0003Nu-UG for 18550@debbugs.gnu.org; Wed, 19 Nov 2014 11:30:26 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xr3Sj-0005vH-VJ for 18550@debbugs.gnu.org; Wed, 19 Nov 2014 18:30:18 +0700 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Thu, 13 Nov 2014 18:14:23 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96229 >>>>> Lars Magne Ingebrigtsen writes: >>>>> Lars Magne Ingebrigtsen writes: >> So I guess eww should set up the `quit-restore' thing properly. >> I'll have a peek. > Actually, that doesn't provide a way to do this (rather obvious) > thing. > Shouldn't there be a way to instruct `quit-window' to go to a > specific buffer (if that buffer is still alive)? I see no reason to abuse quit-window for what=E2=80=99s essentially switching to a buffer to edit one. That is: the eww-restore-history call right after quit-window edits the /current/ buffer. Thus, it indeed makes sense to explicitly use set-buffer before that. (Or to wrap the call in with-current-buffer, anyway.) Moreover, vc.el already uses a dedicated buffer-local variable for a similar purpose, and so does rcirc.el, and perhaps a few more modes out there. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A