unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#27000: 25.2; js-jsx-mode incorrect indentation
@ 2017-05-19 22:45 Renato Ferreira
  2019-06-05  3:09 ` Jackson Ray Hamilton
  0 siblings, 1 reply; 2+ messages in thread
From: Renato Ferreira @ 2017-05-19 22:45 UTC (permalink / raw)
  To: 27000

Hello,

(I don't know if this bug has the same root cause from bug#24986, so my
apologies if it does.)

Using js-jsx-mode produces incorrect indentation on nested JSX elements
when there is an element inside a parentheses inside a JS expression:

function testA() {
	return (
		<div>
			<div> { ( <div/> ) } </div>
				</div>
	);
}

function testB() {
	return (
		<div>
			<div> { <div/> } </div>
		</div>
	);
}

testA indents correctly, but testB does not. This causes all sorts of
indentations problems after an incorrect indented line.

Thanks a lot in advance!





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#27000: 25.2; js-jsx-mode incorrect indentation
  2017-05-19 22:45 bug#27000: 25.2; js-jsx-mode incorrect indentation Renato Ferreira
@ 2019-06-05  3:09 ` Jackson Ray Hamilton
  0 siblings, 0 replies; 2+ messages in thread
From: Jackson Ray Hamilton @ 2019-06-05  3:09 UTC (permalink / raw)
  To: 27000; +Cc: renatofdds

Hi Renato,

A set of changes I pushed to the Emacs master branch 2 months ago should 
resolve this issue.  (First fixed in 4b305bb185, but there were several 
commits after that when I broke/fixed it again.  The master branch is 
your best bet.)

Note that you might not need to use js-jsx-mode any more, either; 
support for JSX should be enabled in js-mode if you include the “React” 
library in a file, or if the file ends in “.jsx”.

Jackson






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-05  3:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-19 22:45 bug#27000: 25.2; js-jsx-mode incorrect indentation Renato Ferreira
2019-06-05  3:09 ` Jackson Ray Hamilton

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).