unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 31710@debbugs.gnu.org, Aria Edm <aria@ar1as.space>
Subject: bug#31710: 26.1; sh-mode doesn't highlight aliases with dots correctly
Date: Sat, 13 Jul 2019 17:34:35 +0200	[thread overview]
Message-ID: <87zhliq778.fsf@igel.home> (raw)
In-Reply-To: <878st2vwy2.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sat, 13 Jul 2019 16:19:33 +0200")

On Jul 13 2019, Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Surely foo[....]="bar" isn't valid bash syntax?

Of course it is.

> I've installed the following patch on the Emacs trunk:
>
> diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
> index ae90531a7f..64608f1930 100644
> --- a/lisp/progmodes/sh-script.el
> +++ b/lisp/progmodes/sh-script.el
> @@ -582,7 +582,7 @@ sh-assignment-regexp
>      ;; actually spaces are only supported in let/(( ... ))
>      (ksh88 . ,(concat "\\<\\([[:alnum:]_]+\\)\\(\\[.+\\]\\)?"
>                        "[ \t]*\\(?:[-+*/%&|~^]\\|<<\\|>>\\)?="))
> -    (bash . "\\<\\([[:alnum:]_]+\\)\\(\\[.+\\]\\)?\\+?=")
> +    (bash . "\\<\\([[:alnum:]_]+\\)\\([.+]\\)?\\+?=")

That doesn't make sense.  A dot or a plus isn't a valid character in a
shell variable.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."





  reply	other threads:[~2019-07-13 15:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04  9:34 bug#31710: 26.1; sh-mode doesn't highlight aliases with dots correctly Aria Edm
2019-07-13 14:19 ` Lars Ingebrigtsen
2019-07-13 15:34   ` Andreas Schwab [this message]
2019-07-13 15:37     ` Lars Ingebrigtsen
2019-07-13 22:00       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhliq778.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=31710@debbugs.gnu.org \
    --cc=aria@ar1as.space \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).