From: Lars Ingebrigtsen <larsi@gnus.org>
To: Aria Edm <aria@ar1as.space>
Cc: 31710@debbugs.gnu.org
Subject: bug#31710: 26.1; sh-mode doesn't highlight aliases with dots correctly
Date: Sat, 13 Jul 2019 16:19:33 +0200 [thread overview]
Message-ID: <878st2vwy2.fsf@mouse.gnus.org> (raw)
In-Reply-To: <87h8mivqs3.fsf@ar1as.space> (Aria Edm's message of "Mon, 04 Jun 2018 19:34:36 +1000")
Aria Edm <aria@ar1as.space> writes:
> run emacs -Q
> M-x sh-mode RET
> alias d="echo hi"
> alias d.="echo hi"
>
> the d is highlighted, d. isn't
Looks like there was a typo in the regexp. At least I think so? Surely
foo[....]="bar" isn't valid bash syntax?
I've installed the following patch on the Emacs trunk:
diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
index ae90531a7f..64608f1930 100644
--- a/lisp/progmodes/sh-script.el
+++ b/lisp/progmodes/sh-script.el
@@ -582,7 +582,7 @@ sh-assignment-regexp
;; actually spaces are only supported in let/(( ... ))
(ksh88 . ,(concat "\\<\\([[:alnum:]_]+\\)\\(\\[.+\\]\\)?"
"[ \t]*\\(?:[-+*/%&|~^]\\|<<\\|>>\\)?="))
- (bash . "\\<\\([[:alnum:]_]+\\)\\(\\[.+\\]\\)?\\+?=")
+ (bash . "\\<\\([[:alnum:]_]+\\)\\([.+]\\)?\\+?=")
(rc . "\\<\\([[:alnum:]_*]+\\)[ \t]*=")
(sh . "\\<\\([[:alnum:]_]+\\)="))
"Regexp for the variable name and what may follow in an assignment.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-07-13 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 9:34 bug#31710: 26.1; sh-mode doesn't highlight aliases with dots correctly Aria Edm
2019-07-13 14:19 ` Lars Ingebrigtsen [this message]
2019-07-13 15:34 ` Andreas Schwab
2019-07-13 15:37 ` Lars Ingebrigtsen
2019-07-13 22:00 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878st2vwy2.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=31710@debbugs.gnu.org \
--cc=aria@ar1as.space \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).