unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 139@debbugs.gnu.org, Mauro Aranda <maurooaranda@gmail.com>,
	jidanni@jidanni.org
Subject: bug#139: describe-key vs. widget red tape
Date: Mon, 07 Oct 2019 03:55:11 +0200	[thread overview]
Message-ID: <87zhidcoao.fsf@gnus.org> (raw)
In-Reply-To: <878spyemgo.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 06 Oct 2019 01:39:35 +0100")

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

>> Find in the attached patch my idea to implement this.
>
> Thank you for working on this!

Yes, it looks really useful.

>> There are some things I would like to ask:
>> - I would like to put an initial value of nil to
>> `describe-actions-functions', and let each library add the function to
>> this list.  Is it OK to use `with-eval-after-load' here?
>
> I think it's best to avoid it, especially in preloaded libraries like
> button.el.

Yes, I think you can just have the libraries push stuff directly to this
variable (and the variable would define be in a library that's preloaded
in Emacs).

>> - I put an autoload cookie in `seq-find', in order to use it in
>> `describe-actions'.  Is it OK?
>
> I think so, but you could also (require 'seq) where it's needed or use
> the already loaded cl-lib library instead.

Putting an autoload cookie there is fine, I think.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2019-10-07  1:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-14 19:25 describe-key vs. widget red tape jidanni
2019-09-30  5:56 ` bug#139: " Lars Ingebrigtsen
2019-09-30  7:31   ` Eli Zaretskii
2019-09-30  7:40     ` Lars Ingebrigtsen
2019-09-30  8:25       ` Eli Zaretskii
2019-09-30 10:54         ` Mauro Aranda
2019-09-30 10:55           ` Mauro Aranda
2019-09-30 14:57           ` Lars Ingebrigtsen
2019-09-30 20:06             ` Mauro Aranda
2019-10-01 12:29               ` Lars Ingebrigtsen
2019-10-05 14:06                 ` Mauro Aranda
2019-10-06  0:39                   ` Basil L. Contovounesios
2019-10-07  1:55                     ` Lars Ingebrigtsen [this message]
2019-10-08 13:04                     ` Mauro Aranda
2019-10-11 14:38                       ` Mauro Aranda
2019-10-11 15:23                         ` Drew Adams
2019-10-11 18:57                         ` Lars Ingebrigtsen
2020-08-07 11:16                           ` Lars Ingebrigtsen
2020-08-07 11:38                             ` Lars Ingebrigtsen
2020-10-31  1:32 ` bug#139: Still can't figure out what the command I used is called 積丹尼 Dan Jacobson
2020-10-31  2:55   ` Thien-Thi Nguyen
2020-10-31 10:33     ` 積丹尼 Dan Jacobson
2021-01-19 18:30   ` bug#139: describe-key vs. widget red tape Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhidcoao.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=139@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=jidanni@jidanni.org \
    --cc=maurooaranda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).