From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#139: describe-key vs. widget red tape Date: Mon, 07 Oct 2019 03:55:11 +0200 Message-ID: <87zhidcoao.fsf@gnus.org> References: <87mynwgrxb.fsf@jidanni.org> <877e5ql42d.fsf@gnus.org> <8336gedyus.fsf@gnu.org> <874l0ugrl4.fsf@gnus.org> <83sgoechsf.fsf@gnu.org> <87v9t9bzng.fsf@gnus.org> <874l0s8x8s.fsf@gnus.org> <878spyemgo.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="101650"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 139@debbugs.gnu.org, Mauro Aranda , jidanni@jidanni.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 07 03:56:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHIG7-000QJS-Pj for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Oct 2019 03:56:23 +0200 Original-Received: from localhost ([::1]:39964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHIG6-0007EZ-MG for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Oct 2019 21:56:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42074) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHIFp-00070u-NJ for bug-gnu-emacs@gnu.org; Sun, 06 Oct 2019 21:56:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHIFo-0005HS-KJ for bug-gnu-emacs@gnu.org; Sun, 06 Oct 2019 21:56:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38224) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHIFo-0005HM-H1 for bug-gnu-emacs@gnu.org; Sun, 06 Oct 2019 21:56:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHIFl-0002r8-Rt for bug-gnu-emacs@gnu.org; Sun, 06 Oct 2019 21:56:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Oct 2019 01:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 139 X-GNU-PR-Package: emacs Original-Received: via spool by 139-submit@debbugs.gnu.org id=B139.157041331810929 (code B ref 139); Mon, 07 Oct 2019 01:56:01 +0000 Original-Received: (at 139) by debbugs.gnu.org; 7 Oct 2019 01:55:18 +0000 Original-Received: from localhost ([127.0.0.1]:47045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHIF4-0002qD-87 for submit@debbugs.gnu.org; Sun, 06 Oct 2019 21:55:18 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:53234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHIF2-0002q5-IH for 139@debbugs.gnu.org; Sun, 06 Oct 2019 21:55:17 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHIEx-0003vU-Ud; Mon, 07 Oct 2019 03:55:14 +0200 In-Reply-To: <878spyemgo.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 06 Oct 2019 01:39:35 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168473 Archived-At: "Basil L. Contovounesios" writes: >> Find in the attached patch my idea to implement this. > > Thank you for working on this! Yes, it looks really useful. >> There are some things I would like to ask: >> - I would like to put an initial value of nil to >> `describe-actions-functions', and let each library add the function to >> this list. Is it OK to use `with-eval-after-load' here? > > I think it's best to avoid it, especially in preloaded libraries like > button.el. Yes, I think you can just have the libraries push stuff directly to this variable (and the variable would define be in a library that's preloaded in Emacs). >> - I put an autoload cookie in `seq-find', in order to use it in >> `describe-actions'. Is it OK? > > I think so, but you could also (require 'seq) where it's needed or use > the already loaded cl-lib library instead. Putting an autoload cookie there is fine, I think. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no