unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: egh@e6h.org, 42184@debbugs.gnu.org, mail@nicolasgoaziou.fr, bzg@gnu.org
Subject: bug#42184: 27.0.91; org-fontify-whole-heading-line does not work in emacs 27
Date: Thu, 06 Aug 2020 00:10:55 -0400	[thread overview]
Message-ID: <87zh782z3k.fsf@kyleam.com> (raw)
In-Reply-To: <87zh88g4e6.fsf@gmail.com> ("Kévin Le Gouguec"'s message of "Thu, 09 Jul 2020 16:16:33 +0200")

Kévin Le Gouguec writes:

> Here is a variant of the previous patch, which correctly resets :extend
> to nil if the user disables the relevant options (after reverting the
> current buffer, or for newly opened ones).
>
> This ends up looking similar to what Org does for org-hide; IMO this
> seems like the most straightforward short-term fix.  In the long run,
> these user options would probably deserve :set functions.

Thanks for working on this fix.  I of course can't speak for Bastien or
Nicolas, but this patch looks fine to me.  Assuming it's okay with Eli,
I'd suggest applying it to the emacs-27 branch.  (Once applied, I'd port
it to the Org repo, as I do with other changes in the Emacs repo that
touch Org files.)

Upstream in the thread you wrote:

> Relatedly (but not crucial to solving this bug), should org-block and
> org-block-background also have :extend t?  It would make sense to me
> since they delimit visual "blocks".

That would make sense to me as well.  (org-block-background hasn't
existed since v8.3, though.)





  reply	other threads:[~2020-08-06  4:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-04  2:29 bug#42184: 27.0.91; org-fontify-whole-heading-line does not work in emacs 27 Erik Hetzner
2020-07-04 17:13 ` Kévin Le Gouguec
2020-07-04 17:18   ` Eli Zaretskii
2020-07-04 17:50     ` Kévin Le Gouguec
2020-07-04 19:52       ` Kévin Le Gouguec
2020-07-05  2:30         ` Eli Zaretskii
2020-07-05  8:57           ` Kévin Le Gouguec
2020-07-05 14:58             ` Eli Zaretskii
2020-07-05 16:02               ` Kévin Le Gouguec
2020-07-05 16:21                 ` Eli Zaretskii
2020-07-08 11:50                 ` Kévin Le Gouguec
2020-07-09 14:16                   ` Kévin Le Gouguec
2020-08-06  4:10                     ` Kyle Meyer [this message]
2020-08-06  9:32                       ` Kévin Le Gouguec
2020-08-06 13:35                       ` Eli Zaretskii
2020-09-06  8:12                         ` Bastien
2020-09-06 14:10                           ` Kévin Le Gouguec
2020-09-06 15:06                             ` Stefan Kangas
2020-09-06 14:19                           ` Kyle Meyer
2020-09-06 15:06                           ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh782z3k.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=42184@debbugs.gnu.org \
    --cc=bzg@gnu.org \
    --cc=egh@e6h.org \
    --cc=kevin.legouguec@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).