From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kyle Meyer Newsgroups: gmane.emacs.bugs Subject: bug#42184: 27.0.91; org-fontify-whole-heading-line does not work in emacs 27 Date: Thu, 06 Aug 2020 00:10:55 -0400 Message-ID: <87zh782z3k.fsf@kyleam.com> References: <5effe96e.1c69fb81.3a20a.f99f@mx.google.com> <87mu4f2ofd.fsf@gmail.com> <83wo3jtd0t.fsf@gnu.org> <87h7un2mq9.fsf@gmail.com> <87y2nzvz13.fsf@gmail.com> <83o8ouu200.fsf@gnu.org> <87blkufif5.fsf@gmail.com> <838sfyt3ej.fsf@gnu.org> <871rlqeyrn.fsf@gmail.com> <871rlm1azl.fsf@gmail.com> <87zh88g4e6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36654"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: egh@e6h.org, 42184@debbugs.gnu.org, mail@nicolasgoaziou.fr, bzg@gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 06 06:12:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3XGF-0009QK-7A for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Aug 2020 06:12:11 +0200 Original-Received: from localhost ([::1]:36824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3XGD-0002OL-MY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Aug 2020 00:12:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3XG6-0002O1-9L for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2020 00:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41061) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3XG6-00039n-0U for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2020 00:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k3XG5-0004WT-LF for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2020 00:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Aug 2020 04:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42184 X-GNU-PR-Package: emacs Original-Received: via spool by 42184-submit@debbugs.gnu.org id=B42184.159668706617318 (code B ref 42184); Thu, 06 Aug 2020 04:12:01 +0000 Original-Received: (at 42184) by debbugs.gnu.org; 6 Aug 2020 04:11:06 +0000 Original-Received: from localhost ([127.0.0.1]:52606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3XFC-0004VG-4U for submit@debbugs.gnu.org; Thu, 06 Aug 2020 00:11:06 -0400 Original-Received: from pb-smtp21.pobox.com ([173.228.157.53]:51017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3XF8-0004Uw-2X for 42184@debbugs.gnu.org; Thu, 06 Aug 2020 00:11:04 -0400 Original-Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 1F16DE8F7A; Thu, 6 Aug 2020 00:11:01 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=/mnDRUWz3g7a 0Z/WjdsHTogCIJA=; b=tSJlfR1Si5XmATEsHfHCGWILQr+TtIoesFm4Y8RlxhdY pTuOF+aczQJNxQv2GSLCVcZWnqhzatAyMnOPfYqutHvpYXy99ZalLHdOcN8ZqpKa eWbJByEjZfClVS94lXk3ZAYyTeygehKfpFkmUFgbttxh/9WrHEO1CumDiScSZw4= Original-Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 1813BE8F79; Thu, 6 Aug 2020 00:11:01 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:references:date:in-reply-to:message-id:mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=5LcaXxAMTao2Cp8GzJ+Nk0JvyCoXdBtVF8E9wz5CwlU=; b=KXjI21d7A9tx6WMWyFfkoRaHqcDOTuBWDQ7NNP9ZREyLH5h3i0TXsThokb1c0awgQLM/kJjXMMo+ExTEkshQWpVg6Hz7+i4+Np2KQfMrnCzFA7u47oH3M1dX0dRQDBN9J2sarJornccOujzUpwDYSCyQhDNqeKLg0sSO0dYf5zI= Original-Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 9EB7BE8F76; Thu, 6 Aug 2020 00:10:58 -0400 (EDT) (envelope-from kyle@kyleam.com) In-Reply-To: <87zh88g4e6.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Thu, 09 Jul 2020 16:16:33 +0200") X-Pobox-Relay-ID: D4FF0202-D79A-11EA-A3D6-843F439F7C89-24757444!pb-smtp21.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184143 Archived-At: K=C3=A9vin Le Gouguec writes: > Here is a variant of the previous patch, which correctly resets :extend > to nil if the user disables the relevant options (after reverting the > current buffer, or for newly opened ones). > > This ends up looking similar to what Org does for org-hide; IMO this > seems like the most straightforward short-term fix. In the long run, > these user options would probably deserve :set functions. Thanks for working on this fix. I of course can't speak for Bastien or Nicolas, but this patch looks fine to me. Assuming it's okay with Eli, I'd suggest applying it to the emacs-27 branch. (Once applied, I'd port it to the Org repo, as I do with other changes in the Emacs repo that touch Org files.) Upstream in the thread you wrote: > Relatedly (but not crucial to solving this bug), should org-block and > org-block-background also have :extend t? It would make sense to me > since they delimit visual "blocks". That would make sense to me as well. (org-block-background hasn't existed since v8.3, though.)