From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 44850@debbugs.gnu.org, pieter-l@vanoostrum.org,
pieter@vanoostrum.org, Alan Third <alan@idiocy.org>
Subject: bug#44850: 27.1; Emacs crash in font handling with font-backend ns
Date: Sun, 29 Nov 2020 10:45:24 +0100 [thread overview]
Message-ID: <87zh30ijij.fsf@gnus.org> (raw)
In-Reply-To: <9ACDC4D8-9B89-4EC7-BF98-F5E7155CCBA7@acm.org> ("Mattias Engdegård"'s message of "Fri, 27 Nov 2020 18:16:48 +0100")
Mattias Engdegård <mattiase@acm.org> writes:
> Yes, the restriction is a bit odd but perhaps there was a good
> reason. For this application, however, we could just switch from
> esprintf to sprintf in nsterm.m. (The stated reason for using esprintf
> was in case the string is longer than 2 GiB but I think we would have
> bigger problems if a frame title ever becomes that long.)
>
> OK for master? (Also fixed the unsightly 'x' while at it)
Like Eli says, this really should be fixed in doprint.c.
However, since this is a crash that makes Emacs unusable, and since (as
you point out) sprintf is unproblematic here, I'm fine with applying the
patch. Perhaps with a FIXME comment about how this should your esprintf
once doprintf has been fixed.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-11-29 9:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 18:09 bug#44850: 27.1; Emacs crash in font handling with font-backend ns Pieter van Oostrum
2020-11-25 14:48 ` Pieter van Oostrum
2020-11-26 11:01 ` Lars Ingebrigtsen
2020-11-26 17:26 ` Pieter van Oostrum
2020-11-26 19:23 ` Eli Zaretskii
2020-11-27 8:16 ` Lars Ingebrigtsen
2020-11-27 9:55 ` Alan Third
2020-11-27 10:04 ` Lars Ingebrigtsen
2020-11-27 10:19 ` Alan Third
2020-11-28 14:23 ` Pieter van Oostrum
2020-11-27 12:23 ` Eli Zaretskii
2020-11-29 18:22 ` Alan Third
2020-11-27 17:16 ` Mattias Engdegård
2020-11-27 18:44 ` Eli Zaretskii
2020-11-29 9:45 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh30ijij.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=44850@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=mattiase@acm.org \
--cc=pieter-l@vanoostrum.org \
--cc=pieter@vanoostrum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).